Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(IAC-1741) Allow stdlib v8.0.0 #1008

Closed
wants to merge 1 commit into from
Closed

(IAC-1741) Allow stdlib v8.0.0 #1008

wants to merge 1 commit into from

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner August 25, 2021 10:24
@smortex smortex mentioned this pull request Aug 26, 2021
Merged
@david22swan
Copy link
Member Author

Unit test failures are on main

@david22swan
Copy link
Member Author

Cannot replicate failures locally

@root-expert root-expert mentioned this pull request Aug 26, 2021
Merged
@smortex
Copy link
Contributor

smortex commented Aug 26, 2021

All the unit test failures are the same, caused by puppetlabs/puppetlabs-stdlib#1196 which resulted in a major bump of stdlib:

expected that the catalogue would contain Package[iptables-services] with ensure set to "present" but it is set to "installed"

The tests should be adjusted to ensure installed instead of present.

@smortex smortex mentioned this pull request Aug 26, 2021
Merged
@david22swan david22swan deleted the IAC-1741/main/stdlib_v8.0.0 branch October 5, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @smortex