Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid empty array to -net parameter #837

Merged
merged 1 commit into from
May 30, 2022
Merged

Avoid empty array to -net parameter #837

merged 1 commit into from
May 30, 2022

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented May 30, 2022

With a configuration of

docker::run{ 'hivemq':
  ensure => present,
  image  => 'foo',
  net    => [],
}

this results in a docker command containing --net '' which then fails.

The original PR for this change was #803 by @traylenator

@traylenator @chelnak
Avoid empty array to -net parameter
6968395 
With a configuration of

```puppet
docker::run{ 'hivemq':
  ensure => present,
  image  => 'foo',
  net    => [],
}
```

this results in a docker command containing `--net ''` which then fails.
@chelnak chelnak added the bugfix label May 30, 2022
@chelnak chelnak requested a review from a team as a code owner May 30, 2022 14:27
@chelnak chelnak self-assigned this May 30, 2022
@puppet-community-rangefinder
Copy link

docker::run is a type

Breaking changes to this file WILL impact these 8 modules (exact match):
Breaking changes to this file MAY impact these 22 modules (near match):

This module is declared in 6 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak chelnak mentioned this pull request May 30, 2022
Closed
@chelnak chelnak merged commit 5d7b9d4 into main May 30, 2022
@chelnak chelnak deleted the GH-803_avoid_empty_array_to_net_parameter branch May 30, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chelnak chelnak

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chelnak @traylenator