allow docker::networks::networks param to be undef #783

jhoblitt · 2021-11-03T22:38:48Z

I would like to include the docker::networks class into the role
(manifest) of nodes which are also including the docker module but not
necessarily always defining docker network(s). This would allow docker
networks to optionally be defined, when needed, via hiera. Currently,
this type of arrangement would require constructing a wrapper class as
the docker::networks::networks parameter is mandatory.

puppet-community-rangefinder · 2021-11-03T22:38:54Z

docker::networks is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 578 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

jhoblitt · 2021-11-15T02:23:16Z

Huh. I can't see any output for the failed acceptance tests. Looks bogus?

jhoblitt · 2022-01-24T16:46:17Z

ping?

CLAassistant · 2022-01-25T04:49:47Z

All committers have signed the CLA.

jhoblitt · 2022-02-11T23:22:00Z

I have resigned the new cla...

jhoblitt · 2022-04-11T21:39:46Z

It appears that CI had glitched and was never kicked...

Rebased on current master.

I would like to include the docker::networks class into the role (manifest) of nodes which are also including the docker module but not necessarily always defining docker network(s). This would allow docker networks to optionally be defined, when needed, via hiera. Currently, this type of arrangement would require constructing a wrapper class as the docker::networks::networks parameter is mandatory.

jhoblitt · 2022-05-03T19:43:54Z

Rebased on current master.

@chelnak ping?

chelnak · 2022-05-03T19:53:58Z

Tests are running now. 😄

jhoblitt · 2022-05-03T22:05:54Z

Thank you to whomever kicked the windows tests!

chelnak · 2022-05-03T22:16:06Z

All tests are passing and I'm happy with the proposed change.

@david22swan I've approved but could you give the change a once over before merge please?

jhoblitt · 2022-05-03T22:39:35Z

LGTM. I am using this in production.

chelnak · 2022-05-04T09:05:27Z

@jhoblitt Merged. Thank you for the contribution.

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

The 4.4.0 release incorporates puppetlabs/puppetlabs-docker#783. It also includes a fix for the docker swarm facts generating error messages in syslog. puppetlabs/puppetlabs-docker#817

jhoblitt requested a review from a team as a code owner November 3, 2021 22:38

adrianiurca added the bugfix label Nov 13, 2021

chelnak added the community label Mar 8, 2022

jhoblitt force-pushed the IHS-5655/docker_net branch from 4e6b4de to 3dc2179 Compare April 11, 2022 21:39

jhoblitt force-pushed the IHS-5655/docker_net branch from 3dc2179 to d116221 Compare May 3, 2022 19:42

jhoblitt force-pushed the IHS-5655/docker_net branch from d116221 to 85e563d Compare May 3, 2022 19:43

chelnak approved these changes May 3, 2022

View reviewed changes

david22swan approved these changes May 4, 2022

View reviewed changes

chelnak merged commit 9e5ff53 into puppetlabs:main May 4, 2022

jhoblitt added a commit to lsst-it/lsst-control that referenced this pull request May 4, 2022

pull puppetlabs/docker from upstream github

cc00d69

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

jhoblitt added a commit to lsst-it/lsst-control that referenced this pull request May 10, 2022

pull puppetlabs/docker from upstream github

2f2eae8

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

jhoblitt added a commit to lsst-it/lsst-control that referenced this pull request May 11, 2022

pull puppetlabs/docker from upstream github

0b39d34

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

jhoblitt added a commit to lsst-it/lsst-control that referenced this pull request May 11, 2022

pull puppetlabs/docker from upstream github

7b2cdcf

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

jhoblitt added a commit to lsst-it/lsst-control that referenced this pull request May 12, 2022

pull puppetlabs/docker from upstream github

6ea8b8f

puppetlabs/puppetlabs-docker#783 has been merged but there hasn't yet been a new forge release.

jhoblitt mentioned this pull request Aug 16, 2022

(Puppetfile) bump puppetlabs/docker to 4.4.0 lsst-it/lsst-control#635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow docker::networks::networks param to be undef #783

allow docker::networks::networks param to be undef #783

jhoblitt commented Nov 3, 2021

puppet-community-rangefinder bot commented Nov 3, 2021

jhoblitt commented Nov 15, 2021

jhoblitt commented Jan 24, 2022

CLAassistant commented Jan 25, 2022 •

edited

Loading

jhoblitt commented Feb 11, 2022

jhoblitt commented Apr 11, 2022

jhoblitt commented May 3, 2022

chelnak commented May 3, 2022

jhoblitt commented May 3, 2022 •

edited

Loading

chelnak commented May 3, 2022

jhoblitt commented May 3, 2022

chelnak commented May 4, 2022

allow docker::networks::networks param to be undef #783

allow docker::networks::networks param to be undef #783

Conversation

jhoblitt commented Nov 3, 2021

puppet-community-rangefinder bot commented Nov 3, 2021

docker::networks is a class

This module is declared in 6 of 578 indexed public Puppetfiles.

jhoblitt commented Nov 15, 2021

jhoblitt commented Jan 24, 2022

CLAassistant commented Jan 25, 2022 • edited Loading

jhoblitt commented Feb 11, 2022

jhoblitt commented Apr 11, 2022

jhoblitt commented May 3, 2022

chelnak commented May 3, 2022

jhoblitt commented May 3, 2022 • edited Loading

chelnak commented May 3, 2022

jhoblitt commented May 3, 2022

chelnak commented May 4, 2022

This module is declared in 6 of 578 indexed public `Puppetfiles`.

CLAassistant commented Jan 25, 2022 •

edited

Loading

jhoblitt commented May 3, 2022 •

edited

Loading