(MAINT) Use docker-compose config instead file parsing #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 22.37% 22.28% -0.09%
==========================================
Files 20 20
Lines 751 754 +3
==========================================
Hits 168 168
- Misses 583 586 +3
Continue to review full report at Codecov.
|
Otherwise warnings get parsed incorrectly as yaml
|
Thanks so much for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing the files directly causes issues for variable interpolation in the docker-compose.yml files. For example, the common image name
image:${IMAGE_TAG:-latest}in a docker-compose.yml will never be found without docker-compose finding $IMAGE_TAG and substituting it.docker-compose configwill also merge the compose files properly without the provider needing to parse and merge manually.My ruby is barely passable, so there may be significant improvements here.