Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining the name of the docker-compose symlink #544

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Allow defining the name of the docker-compose symlink #544

merged 1 commit into from
Nov 18, 2019

Conversation

gtufte
Copy link

@gtufte gtufte commented Oct 30, 2019

I bumped into a problem with docker-compose where every docker-compose command failed with:

docker compose: Error while loading shared libraries: libz.so.1: failed to map segment from shared object: Operation not permitted

Found out it's related to docker-composes use of the environment variable TMPDIR, usually pointing to /tmp or /var/tmp, and that docker-compose expects to be able to run scripts from this path. Being able to run scripts from these locations is not a security best practice, so I made a wrapper script installed at /usr/local/bin/docker-compose where I set TMPDIR to a safer location, before running the actual docker-compose binary. This wrapper script now conflicts with the default symlink file created by this fabulous module, so this PR adds the ability to give this symlink another name.

The issues I'm referring to is also described in more detail on this stackoverflow post:
https://stackoverflow.com/questions/57796839/docker-compose-error-while-loading-shared-libraries-libz-so-1-failed-to-map-s

…support using own docker-compose wrapper scripts installed at /usr/local/bin/docker-compose
@gtufte gtufte requested a review from a team as a code owner October 30, 2019 14:46
@florindragos
Copy link
Contributor

Hello @gtufte,
Thanks for your contribution!
Fix looks good. I'll run the acceptance tests and merge it if everything is ok.

@florindragos florindragos merged commit 7748f7f into puppetlabs:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants