-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUD-2069 Adding support for multiple compose files. #332
Merged
florindragos
merged 11 commits into
puppetlabs:master
from
MWilsonPuppet:CLOUD-2069-support-for-multiple-compose-files
Sep 26, 2018
Merged
CLOUD-2069 Adding support for multiple compose files. #332
florindragos
merged 11 commits into
puppetlabs:master
from
MWilsonPuppet:CLOUD-2069-support-for-multiple-compose-files
Sep 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80b63d
to
0b59c61
Compare
129596d
to
251fab4
Compare
251fab4
to
39e70c9
Compare
8ae3f0b
to
c314885
Compare
c314885
to
4e7b3fd
Compare
4e7b3fd
to
a726a5f
Compare
20775b1
to
016126a
Compare
@MWilsonPuppet can you pull in the fix for the acceptance tests on windows from here? florindragos@cec5325 After this, looks good |
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple compose files. Acceptance tests have been added and verified passing. I verified manually also that the services was being overriden by additional compose file and have updated the readme to reflect the changes to the docker_compose type and provider.