Use versioncmp instead of type casting #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failed. Is this casting instead of type annotation ? YGTBKM ;-) |
|
I have changed the cast to |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to request the removal of this particular type annotation.
The annotation is what remains from the fork of
puppetlabs-dockerI maintain to make the module work with language-puppet. Language-puppet helps us tremendously when writing puppet configuration.The annotation itself does not seem to bring any kind of type safety. I would argue it is not the right place to check the type of this particular global fact if such a check is at all necessary.
language-puppet is making great effort to be as compatible with the puppet language as possible. See recent commit. This particular idiom might be supported in the future but for now I am just requesting this change because all in all it seems to make sense.
Thanks you.