Moved the docker run command to a separate file in /usr/local/bin and… #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… referenced that file in the systemd service unit. Fixes #259
|
I ran the acceptance test for vagrant:debian-81-x64. That one worked except for one failure where it was complaining about the wrong storage driver, but in my analysis I found, that this wasn't because of my changes. Is that a known issue? |
|
It looks like on vagrant, the default driver is aufs, and on pooler which we use internally its overlay2. We'll look at a work around but that doesn't affect the validity of your PR in this case. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… referenced that file in the systemd service unit. Fixes #259