Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -o option when downloading docker compose #162

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

alexjfisher
Copy link
Contributor

Fixes #159

Also use the -S option. From curl's man page.

-S, --show-error
When used with -s it makes curl show an error message if it fails.

Fixes puppetlabs#159

Also use the `-S` option.  From curl's man page.
> -S, --show-error
>   When used with -s it makes curl show an error message if it fails.

There were also two separate spec files for the docker::compose class.
I've moved the examples from spec/unit/compose_spec.rb into
spec/classes/compose_spec.rb
@scotty-c
Copy link
Contributor

LGTM

@scotty-c scotty-c merged commit 6c56654 into puppetlabs:master Feb 19, 2018
@davejrt davejrt added this to the v1.1.0 milestone Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants