Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PPA in deb822 format #1169

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Support PPA in deb822 format #1169

merged 3 commits into from
Dec 18, 2024

Conversation

fredericgiquel
Copy link

Summary

Since Ubuntu 23.10, add-apt-repository no longer creates a .list file but a .sources file (in deb822 format).

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@fredericgiquel fredericgiquel requested review from bastelfreak, smortex and a team as code owners March 12, 2024 09:09
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kenyon
kenyon approved these changes Mar 12, 2024
View reviewed changes
Copy link

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #1167.

manifests/ppa.pp Outdated Show resolved Hide resolved
@kenyon kenyon mentioned this pull request Jul 2, 2024
Closed
3 tasks
@logansymons logansymons mentioned this pull request Oct 14, 2024
Closed
@grant-veepshosting grant-veepshosting mentioned this pull request Oct 16, 2024
Merged
3 tasks
@grant-veepshosting
Copy link

grant-veepshosting commented Oct 16, 2024 •
edited
Loading

There seems to be an extra leading $ character on L59 in manifests/ppa.pp main branch.

kenyon
kenyon reviewed Oct 17, 2024
View reviewed changes
manifests/ppa.pp Outdated Show resolved Hide resolved
@grant-veepshosting
Copy link

@smortex is there a chance you could look at merging this PR (and the related one)?

@kenyon kenyon mentioned this pull request Nov 21, 2024
Merged
3 tasks
@amitkarsale
Copy link

Is this PR good the be merged, all checks are passing?

fredericgiquel and others added 3 commits November 27, 2024 11:58
@fredericgiquel @amitkarsale
Support PPA in deb822 format
3f86062
@fredericgiquel @kenyon @amitkarsale
A bit less repetition
b301bef 
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
@fredericgiquel @kenyon @amitkarsale
Fix typo
cd4653c 
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
david22swan
david22swan approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, though would be best to run the tests against an Ubuntu 24.04 machine first to confirm.

@malikparvez malikparvez merged commit 30e8065 into puppetlabs:main Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@malikparvez malikparvez malikparvez approved these changes

@david22swan david22swan david22swan approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fredericgiquel @CLAassistant @grant-veepshosting @amitkarsale @kenyon @david22swan @malikparvez @bastelfreak @ia-content