Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10960) Selector needs multiple checks in brackets. #369

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented Mar 4, 2021

@tuxmea tuxmea requested a review from a team as a code owner March 4, 2021 09:58
@puppet-community-rangefinder
Copy link

accounts::user is a type

Breaking changes to this file WILL impact these 3 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 3 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4426c1d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #369   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       2           
  Lines           ?      30           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      30           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4426c1d...05056e9. Read the comment docs.

@tuxmea tuxmea changed the title Selector needs multiple checks in brackets. (MODULES-10960) Selector needs multiple checks in brackets. Mar 4, 2021
@tuxmea
Copy link
Contributor Author

tuxmea commented Mar 4, 2021

CentOS 6 failures are unrelated to this PR. Issue is with packages and repositories.

@pmcmaw
Copy link
Contributor

pmcmaw commented Mar 8, 2021

I can confirm the failure being seen is transient.
Thank you for your PR @tuxmea as always, we really appreciate your contribution.

@pmcmaw pmcmaw merged commit 2e94c41 into puppetlabs:main Mar 8, 2021
@tuxmea tuxmea deleted the tuxmea_fix_sshkey_purge branch March 8, 2021 17:12
@pmcmaw pmcmaw added the bugfix label Mar 15, 2021
@pmcmaw
Copy link
Contributor

pmcmaw commented Mar 16, 2021

@tuxmea
Just to make you aware if you haven't already noticed, this module was released with your fix yesterday :-)
Thank you for your contributions to Puppet :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants