(MODULES-10892) Update name.pp

[LooOOooM]

bugfix: MODULES-10892
https://tickets.puppetlabs.com/projects/MODULES/issues/MODULES-10892?filter=allissues

[sheenaajay]

Thank you @LooOOooM for submitting the PR.
The unit test cases failing with the following changes.

Invalid user name values "1-bad-dude" is expected not to match value "1-bad-dude" (FAILED - 1) ".hidden" is expected not to match value ".hidden" (FAILED - 2)

Could you please check the following, the updated regex are not satisfying the following username rules.

• Fully numeric usernames and usernames . or .. are also disallowed
• It is not recommended to use usernames beginning with . character as their home directories will be hidden in
• the ls output

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Timo Bergemann
❌ LooOOooM

---

Timo Bergemann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[pmcmaw]

Hey @LooOOooM :-)

Just wondering if you have any bandwidth to work on this so we can get it merged :-)

[LooOOooM]

done

[pmcmaw]

Hey @LooOOooM :-)

I want to thank you for taking the time to make this change however, 1-bad-dude would be an acceptable username therefore should remain in our tests. The change would be expected to go into the regex pattern to both accommodate for existing tests and also your own use case.

[LooOOooM]

sry, I dont get it? is there anything left to do apart from finnaly getting this into production? As of course "1-bad-dude" is a valid username it should get removed out of the test, as the test is a negativ one. The test is failing as the regex is matching "1-bad-dude", However 1-bad-dude is not a fancy name:

[root@puppet-centos7-testvm1 ~]# useradd -m 1-bad-dude
[root@puppet-centos7-testvm1 ~]# echo $?
0
[root@puppet-centos7-testvm1 ~]# tail -1 /etc/passwd
1-bad-dude:x:1009:1010::/home/1-bad-dude:/bin/bash
[root@puppet-centos7-testvm1 ~]# su - 1-bad-dude

This might be for specific distriputions (like debian based) differnet, but for redhat based it is not.
Therefore I think the module should leave the restrictions to the distribution rather then forcing debian best rule out to other distribitions.

[pmcmaw]

@LooOOooM

Im really sorry, I missed the fact it was a negative test.

Would you mind dropping the test into the valid usernames list here:

puppetlabs-accounts/spec/type_aliases/user_name_spec.rb

Line 6 in cc2e789

describe 'Valid user name values' do

Once done I will merge.

[LooOOooM]

done

[pmcmaw]

Thank you and again I apologize for the oversight on my behalf with the test update.