Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Sensitive type passwords in accounts::user #333

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Allow for Sensitive type passwords in accounts::user #333

merged 1 commit into from
Sep 4, 2020

Conversation

jarretlavallee
Copy link

This PR adds the capability of passing in a Sensitive type password parameter to the accounts::user resource. The user resource already accepts the Sensitive type, so its a small change.

@jarretlavallee jarretlavallee requested a review from a team as a code owner August 25, 2020 20:25
@puppet-community-rangefinder
Copy link

accounts::user is a type

Breaking changes to this file WILL impact these 3 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 3 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@david22swan
Copy link
Member

@jarretlavallee Thanks for the work. While it looks god overall I would be more comfortable if an acceptance test was added to coverthis functionality as well as a unit test. Also if you could update the reference information in the manifest to reference in the manifest to refer to the change.
If you could get both those things down I would be more than happy to merge.

Prior to this commit, the `password` type was only string, while the
`user` resource could handle Sensitive types. This commit allows for
sending in a Sensitive type password to the accounts::user resource.
@jarretlavallee
Copy link
Author

@david22swan Thanks for taking the time to review this. I added an acceptance test for this and ran puppet-strings to update the REFERENCE.md. What would you suggest for the unit testing?

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@11edfd0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             main    #333   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       2           
  Lines           ?      30           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      30           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11edfd0...a639026. Read the comment docs.

@daianamezdrea
Copy link
Contributor

Hi @jarretlavallee, great job, thank you for you fast responses! Actually, you already have an unit test in spec/defines/accounts_user_spec.rb. Cheers !

@daianamezdrea daianamezdrea merged commit 1f9a8f2 into puppetlabs:main Sep 4, 2020
@jarretlavallee jarretlavallee deleted the feat/main/sensitive_password branch September 4, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants