Employ more lenient username checks (allow capitals) #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is an exception for periods on the basis that "some installations allow it", i don't see why there shouldn't be an exception for capitals. Seperately, older versions of this puppet module had no restriction on capitals, so enforcing them now breaks things even though the underlying OS has no problem with it, this does not fare well with users who potentially need to rework puppet code & fix or replace existing systems.
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
=======================================
Coverage ? 0%
=======================================
Files ? 1
Lines ? 19
Branches ? 0
=======================================
Hits ? 0
Misses ? 19
Partials ? 0Continue to review full report at Codecov.
|
|
Thank you @mvandegarde for your contribution. The changes look good, Much appreciated the test case changes and very clear commit message. Good Job.Well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.