Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-9697) fix for correct management of sshkey_custom_path #242

Merged
merged 1 commit into from
Aug 12, 2019
Merged

(MODULES-9697) fix for correct management of sshkey_custom_path #242

merged 1 commit into from
Aug 12, 2019

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented Aug 8, 2019

This PR adds some tests where we see issues at customers:

  1. changing group id
  2. setting a custom ssh key path

More to come. Waiting for Jenkins pipeline results...

@tuxmea tuxmea force-pushed the add_more_accpetance_tests branch 5 times, most recently from 4cb5a11 to e9344fa Compare August 8, 2019 13:11
pillarsdotnet
pillarsdotnet reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@pillarsdotnet pillarsdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, the key file for a user is owned by that user.

@tuxmea
Copy link
Contributor Author

tuxmea commented Aug 8, 2019

Normally, the key file for a user is owned by that user.

Not when using a global location.
But issue is different: no keyfile created:

expected `File "/test/sshkeys/hunner".file?` to return true, got false

@tuxmea tuxmea force-pushed the add_more_accpetance_tests branch 2 times, most recently from bb557fd to 9947cd0 Compare August 8, 2019 14:21
@pillarsdotnet
Copy link
Contributor

Normally, the key file for a user is owned by that user.

Not when using a global location.
But issue is different: no keyfile created:

expected `File "/test/sshkeys/hunner".file?` to return true, got false

Also see https://tickets.puppetlabs.com/browse/MODULES-9578

pillarsdotnet
pillarsdotnet approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@pillarsdotnet pillarsdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tuxmea tuxmea force-pushed the add_more_accpetance_tests branch 2 times, most recently from 240a8e1 to b017960 Compare August 8, 2019 17:10
@tuxmea tuxmea changed the title WIP: add more tests which cause errors at customers add more tests and fixes for errors Aug 8, 2019
@tuxmea
Copy link
Contributor Author

tuxmea commented Aug 8, 2019

fixes https://tickets.puppetlabs.com/browse/MODULES-9697

@tuxmea tuxmea changed the title add more tests and fixes for errors fix for correct management of sshkey_custom_path Aug 8, 2019
@tuxmea tuxmea changed the title fix for correct management of sshkey_custom_path (MODULES-9697) fix for correct management of sshkey_custom_path Aug 8, 2019
@tuxmea tuxmea force-pushed the add_more_accpetance_tests branch from b017960 to 86730d6 Compare August 12, 2019 09:59
@tuxmea
Copy link
Contributor Author

tuxmea commented Aug 12, 2019

add new parameter in alphabetical order.

@lionce
Copy link
Contributor

lionce commented Aug 12, 2019

https://pipelines.puppet.com/team-modules/builds/575113

@lionce
Copy link
Contributor

lionce commented Aug 12, 2019

Hello @tuxmea ,

Looks good to me. 👍 Thank you for this contribution!

Cheers!

@lionce lionce merged commit b16bf19 into puppetlabs:master Aug 12, 2019
@tuxmea tuxmea deleted the add_more_accpetance_tests branch August 12, 2019 17:33
@lionce lionce added the bugfix label Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pillarsdotnet pillarsdotnet pillarsdotnet approved these changes

@lionce lionce lionce approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuxmea @pillarsdotnet @lionce