Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user when custom sshkey file is set #213

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Remove user when custom sshkey file is set #213

merged 1 commit into from
Mar 20, 2019

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented Mar 17, 2019

@tuxmea tuxmea force-pushed the remove_user_with_custom_sshkey_file branch 6 times, most recently from 79bedc8 to 88a9878 Compare March 18, 2019 09:11
@eimlav
Copy link
Contributor

eimlav commented Mar 20, 2019

Hi @tuxmea. This looks good to me except for one minor change. Would it be possible to update your commit to include the ticket number as well? Cheers!

@eimlav eimlav added the bugfix label Mar 20, 2019
@tuxmea tuxmea force-pushed the remove_user_with_custom_sshkey_file branch from 88a9878 to dd4f0f8 Compare March 20, 2019 11:12
@tuxmea tuxmea force-pushed the remove_user_with_custom_sshkey_file branch from dd4f0f8 to e509bdb Compare March 20, 2019 11:32
@eimlav
Copy link
Contributor

eimlav commented Mar 20, 2019

Adhoc ran successfully. Thanks for fixing this issue @tuxmea

Screen Shot 2019-03-20 at 13 41 04

@eimlav eimlav merged commit 7076981 into puppetlabs:master Mar 20, 2019
@tuxmea tuxmea deleted the remove_user_with_custom_sshkey_file branch March 20, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eimlav eimlav eimlav approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxmea @eimlav