(FM-7287) - i18n Process Implemented. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
approved these changes
Aug 21, 2018
pmcmaw
requested changes
Aug 21, 2018
There was a problem hiding this comment.
Apologies clicked on the wrong button above and approved by accident.
-
I would recommend adding tests using unicode translations. This is currently not being tested in anyway to see if it works. Example available in puppetlabs-mysql (instead of actual Japanese introduce unicode, info on confluence).
-
This is a very old version of the pdk (you would run it against 1.7.0)
-
There is a lot going on, you could split your commits up, one being the Gem & module addition, one being pdk update, final one being string decoration.
|
|
Includes setup necessary for said process.
Relevant strings have been decorated with the translate code. .pot files have been generated and pushed.
|
Difference between adhoc and current is just from rebasing onto master following pdksync merge. |
|
|
|
Updated adhoc run |
pmcmaw
approved these changes
Aug 22, 2018
|
Fantastic changes! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant strings have been decorated with the translate code.
.pot files have been generated and pushed.
Also includes a minor PDK update.