-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-5222) - managevim option added to manifests. #156
Conversation
manifests/home_dir.pp
Outdated
@@ -40,6 +43,7 @@ | |||
define accounts::home_dir( | |||
String $user, | |||
String $group, | |||
Boolean $managevim = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be set or be Optional.
manifests/home_dir.pp
Outdated
@@ -40,6 +43,7 @@ | |||
define accounts::home_dir( | |||
String $user, | |||
String $group, | |||
Boolean $managevim = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be Optional if it can be undef.
manifests/user.pp
Outdated
@@ -221,6 +225,7 @@ | |||
groups => $groups, | |||
membership => $membership, | |||
managehome => $managehome, | |||
# managevim => $managevim, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be commented out.
manifests/user.pp
Outdated
@@ -237,6 +242,7 @@ | |||
groups => $groups, | |||
membership => $membership, | |||
managehome => $managehome, | |||
# managevim => $managevim, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be commented out.
When set to false .vim file is not created. Defaults to true.
When set to false .vim file is not created. Defaults to true.
e.g.