Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-5222) - managevim option added to manifests. #156

Merged
merged 1 commit into from
Aug 21, 2018
Merged

(MODULES-5222) - managevim option added to manifests. #156

merged 1 commit into from
Aug 21, 2018

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Aug 20, 2018

When set to false .vim file is not created. Defaults to true.

e.g.

accounts::user { 'hunner':
            groups               => ['root'],
            password             => 'hi',
            shell                => '/bin/true',
            home                 => '/test/hunner',
            home_mode            => '0700',
            managevim            => false,
            bashrc_content       => file('accounts/shell/bashrc'),
            bash_profile_content => file('accounts/shell/bash_profile'),
            sshkeys              => [
              'ssh-rsa #{test_key} vagrant',
              'command="/bin/echo Hello",from="myhost.example.com,192.168.1.1" ssh-rsa #{test_key} vagrant2'
            ],
          }

@david22swan david22swan requested a review from pmcmaw August 21, 2018 10:04
@@ -40,6 +43,7 @@
define accounts::home_dir(
String $user,
String $group,
Boolean $managevim = undef,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be set or be Optional.

@@ -40,6 +43,7 @@
define accounts::home_dir(
String $user,
String $group,
Boolean $managevim = undef,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be Optional if it can be undef.

@@ -221,6 +225,7 @@
groups => $groups,
membership => $membership,
managehome => $managehome,
# managevim => $managevim,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be commented out.

@@ -237,6 +242,7 @@
groups => $groups,
membership => $membership,
managehome => $managehome,
# managevim => $managevim,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be commented out.

When set to false .vim file is not created.
Defaults to true.
@pmcmaw pmcmaw merged commit 9373f0f into puppetlabs:master Aug 21, 2018
@david22swan david22swan deleted the MODULES-5222 branch August 21, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants