(PDK-996) Provide better messaging when type cannot be resolved #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
reviewed
May 31, 2018
lib/puppet/resource_api.rb
Outdated
| end | ||
| Puppet::ResourceApi::TypeShim.new(resource_hash, name, context.type.namevars, attr_def) | ||
| rescue NoMethodError => e |
There was a problem hiding this comment.
- This might hide/modify errors from the
get()call itself. - This is relevant to PDK-917, but the commit is not tagged
- There are many more calls of
get()relevant to PDK-917 that need checking - I've updated pdk-917 to be more specific about what has to be checked
There was a problem hiding this comment.
Have removed this commit from the PR, will work on separately for PDK-917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains:
Better messaging when provider.get does not return correctly
(maint) Pre-commit hook should now properly deal with stages changes