Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-889) Write support for multiple namevars #79

Merged
merged 5 commits into from
May 21, 2018
Merged

(PDK-889) Write support for multiple namevars #79

merged 5 commits into from
May 21, 2018

Conversation

da-ar
Copy link

@da-ar da-ar commented May 18, 2018

No description provided.

willmeek
willmeek approved these changes May 21, 2018
View reviewed changes
Copy link

@willmeek willmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work
Get Travis green and good to go!

DavidS
DavidS approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with a bunch of minor fixes, and more tests. Let's merge this once CI goes 💚

@DavidS
Add apply-based acceptance tests
1b0ce3d 
This also fixes the multiple_namevar provider to remember newly added
resources.
@da-ar da-ar merged commit 11a7882 into puppetlabs:master May 21, 2018
@da-ar da-ar deleted the multiple_namevars_title branch May 21, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS approved these changes

@willmeek willmeek willmeek approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da-ar @DavidS @willmeek