Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PE-38111) 3.0.1 release prep #269

Merged
merged 1 commit into from
Apr 10, 2024
Merged

(PE-38111) 3.0.1 release prep #269

merged 1 commit into from
Apr 10, 2024

Conversation

shubhamshinde360
Copy link
Contributor

  • This release is required to add support for sles-11 (main) builds to be installed in CI.

@shubhamshinde360 shubhamshinde360 added the maintenance Use for non-code related changes, such as release prep label Apr 8, 2024
@shubhamshinde360 shubhamshinde360 requested review from a team as code owners April 8, 2024 14:57
steveax
steveax reviewed Apr 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@steveax
Copy link
Contributor

steveax commented Apr 8, 2024

Tests are failing with a 404 for SLES 12:

    Error: 'curl  -f -L -o puppet-agent-sles-12-x86_64.tar.gz https://pm.puppetlabs.com/puppet-agent/2023.7.0-rc1-245-g32dd2f2/8.5.1.73/repos/puppet-agent-sles-12-x86_64.tar.gz' returned 22 instead of one of [0]
    Error: /Stage[main]/Pe_repo::Platform::Sles_12_x86_64/Pe_repo::Sles[sles-12-x86_64]/Pe_repo::Repo[sles-12-x86_64 2023.7.0-rc1-245-g32dd2f2]/Pe_staging::Deploy[puppet-agent-sles-12-x86_64.tar.gz]/Pe_staging::File[puppet-agent-sles-12-x86_64.tar.gz]/Exec[/opt/puppetlabs/server/data/staging/pe_repo-puppet-agent-8.5.1.73/puppet-agent-sles-12-x86_64.tar.gz]/returns: change from 'notrun' to ['0'] failed: 'curl  -f -L -o puppet-agent-sles-12-x86_64.tar.gz https://pm.puppetlabs.com/puppet-agent/2023.7.0-rc1-245-g32dd2f2/8.5.1.73/repos/puppet-agent-sles-12-x86_64.tar.gz' returned 22 instead of one of [0] (corrective)
    Notice: /Stage[main]/Pe_repo::Platform::Sles_12_x86_64/Pe_repo::Sles[sles-12-x86_64]/Pe_repo::Repo[sles-12-x86_64 2023.7.0-rc1-245-g32dd2f2]/Pe_staging::Deploy[puppet-agent-sles-12-x86_64.tar.gz]/Pe_staging::Extract[puppet-agent-sles-12-x86_64.tar.gz]/Exec[extract puppet-agent-sles-12-x86_64.tar.gz]: Dependency Exec[/opt/puppetlabs/server/data/staging/pe_repo-puppet-agent-8.5.1.73/puppet-agent-sles-12-x86_64.tar.gz] has failures: true
    Warning: /Stage[main]/Pe_repo::Platform::Sles_12_x86_64/Pe_repo::Sles[sles-12-x86_64]/Pe_repo::Repo[sles-12-x86_64 2023.7.0-rc1-245-g32dd2f2]/Pe_staging::Deploy[puppet-agent-sles-12-x86_64.tar.gz]/Pe_staging::Extract[puppet-agent-sles-12-x86_64.tar.gz]/Exec[extract puppet-agent-sles-12-x86_64.tar.gz]: Skipping because of failed dependencies
    Notice: Applied catalog in 27.18 seconds
  
  non-hamburger.delivery.puppetlabs.net (non-hamburger.delivery.puppetlabs.net) executed in 43.64 seconds
  Exited: 4

@shubhamshinde360
Copy link
Contributor Author

Hey @steveax,
I re-triggered the pipeline today and it passed all checks. Could you please re-review this? Thanks!

steveax
steveax approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@steveax steveax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@steveax steveax merged commit a5dc064 into puppetlabs:main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveax steveax steveax approved these changes

Assignees
No one assigned
Labels
maintenance Use for non-code related changes, such as release prep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamshinde360 @steveax