(PE-34110) Add ability to inject flags to be passed to configure action #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the ability to pass flags into the configure action in order to skip the versioned_deploy check (e.g. 'puppet-enterprise-installer -y -- --skip-versioned-deploy-check'). When this is set on the host object or in options, this string containing the flags will be added to the installer command.
|
Tested with a standalone postgres install and setting |
|
Tests are failing for the issue noted in voxpupuli/beaker#1747. Logic there needs a bit of tweaking. |
|
Failing for an inifile thing unrelated to this PR. Going to merge anyway since we need to get CI green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to pass flags into the configure action in order to skip the versioned_deploy check (e.g. 'puppet-enterprise-installer -y -- --skip-versioned-deploy-check'). When this is set on the host object or in options, this string containing the flags will be added to the installer command.