Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix touch support #444

Merged
merged 4 commits into from
Sep 3, 2022
Merged

fix touch support #444

merged 4 commits into from
Sep 3, 2022

Conversation

dmg-hamann
Copy link

@dmg-hamann dmg-hamann commented Jun 9, 2022

What changed?

Added the code @KKauK suggested in #418 and enhanced Showcase to test touch. I was able to test on a touch panel and after the adjustments it works fine.

Closes #418

@jizc
Copy link
Contributor

jizc commented Jun 9, 2022

I'm sure this was unintentional, but your PR reverts the changes from #426 and #430. You may want to rebase.

@dmg-hamann
Copy link
Author

Oh Im sorry. I'll fix that.

@dmg-hamann dmg-hamann closed this Jun 9, 2022
@dmg-hamann dmg-hamann reopened this Jun 9, 2022
@dmg-hamann
Copy link
Author

I made the mistake to use the files mentioned in the issue which were based on an older commit and I replaced the whole content. I merged the code

@las-nsc
Copy link

las-nsc commented Jul 28, 2022

@dmg-hamann @punker76, any chance of getting this in? It's making our solution unusable.

@punker76
Copy link
Owner

@las-nsc I am still on holiday. Next week I can have a look at this.

@John-Welch
Copy link

(@las-nsc's colleague here)
@punker76 Do you have a rough idea when this might be merged and pushed into NuGet? We'd much prefer to pick up an updated package from there than have to fork the repo and apply the PR locally to get the fix for our solution.

@punker76 punker76 merged commit c148ea1 into punker76:develop Sep 3, 2022
@punker76
Copy link
Owner

punker76 commented Sep 3, 2022

@dmg-hamann your changes have been merged, thanks for your contribution 👍

@John-Welch
Copy link

Thanks very much for the fix - I've upgraded to 3.2.0 using NuGet and the propblem has gone away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag&Drop on a touch device
5 participants