Enable custom IDragInfo & IDropInfo implementations #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff417c1 to
57c9116
Compare
|
@jizc your changes have been merged, thanks for your contribution 👍 |
|
Thanks for merging! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The new
IDragInfoBuilderandIDropInfoBuilderare great, but there are still some scenarios where it's not possible to override default behavior.This PR further embraces the
IDragInfoandIDropInfointerfaces, enabling more custom implementations.I needed this when implementing drag-n-drop for a custom multi selection tree view.
Breaking changes
IDragInfoBuilder.CreateDragInfonow returnsIDragInfoinstead ofDragInfoIDropInfoBuilder.CreateDropInfonow takes anIDragInfoinstead ofDragInfoRefreshSourceItemsmethod added toIDragInfo. This is not really a breaking change, as up until this PR, it wasn't possible to use a fully custom implementation ofIDragInfoand any existing implementations will be inheriting fromDragInfo.