Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DefaultDropHandler.TestCompatibleTypes for any IEditableCollectionView #338

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

dauthleikr
Copy link
Contributor

@dauthleikr dauthleikr commented Nov 29, 2019

In the DefaultDropHandler:
TestCompatibleTypes does not consider any IEditableCollectionView:

...
else
{
    return target is IList;
}

This causes CanAcceptData to always reject any targets that are IEditableCollectionView, however Drop is able to handle them.

I simply modified it to:

return target is IList || target is IEditableCollectionView;

I also added some minor cleanups for the same function.

@punker76 punker76 added this to the vNext milestone Dec 4, 2019
@punker76 punker76 modified the milestones: vNext, 2.2.0 Dec 4, 2019
@punker76 punker76 merged commit a0f31d1 into punker76:dev Dec 4, 2019
@punker76
Copy link
Owner

punker76 commented Dec 4, 2019

@dauthleikr your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants