Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds and repairs pre-commit, removes pickling of FunctionalCorrector #124

Merged
merged 14 commits into from
Dec 18, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 14, 2023

As part of making pre-commit happy, pickling of FunctionalCorrectors was removed.

Created by Github action

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a3e58f4) 94.71% compared to head (f19f783) 94.54%.
Report is 4 commits behind head on main.

Files Patch % Lines
setup.py 0.00% 3 Missing ⚠️
regularizepsf/corrector.py 92.59% 2 Missing ⚠️
regularizepsf/fitter.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   94.71%   94.54%   -0.17%     
==========================================
  Files          11       11              
  Lines        1021     1027       +6     
==========================================
+ Hits          967      971       +4     
- Misses         54       56       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes changed the title Weekly merge to develop Weekly merge from develop Dec 15, 2023
@jmbhughes
Copy link
Member

jmbhughes commented Dec 16, 2023

This needs to wait on fixes from #123 . Those changes will likely warrant releasing a new version.

@jmbhughes jmbhughes self-requested a review December 16, 2023 01:07
@jmbhughes jmbhughes changed the title Weekly merge from develop Adds and repairs pre-commit Dec 18, 2023
@jmbhughes jmbhughes changed the title Adds and repairs pre-commit Adds and repairs pre-commit, removes pickling of FunctionalCorrector Dec 18, 2023
@jmbhughes jmbhughes merged commit 9f566a9 into main Dec 18, 2023
5 of 7 checks passed
@jmbhughes jmbhughes self-assigned this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant