Ignore multiple duplicate port declarations #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e2f788 to
a4861a9
Compare
|
The only problem here is that legit uses of bind multiple times will now warn. Issuing the uniq! is probably enough. |
a4861a9 to
3f2fb13
Compare
|
I removed the warning. |
Right now if you specify a port via `-p $PORT` and via a `config/puma.rb` then puma will incorrectly try to bind to the same port twice and will fail. This PR calls `uniq!` on the array to remove duplicate ports from the `binds` array.
evanphx
added a commit
that referenced
this pull request
Feb 19, 2015
Ignore multiple duplicate port declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you specify a port via
-p $PORTand via aconfig/puma.rbthen puma will incorrectly try to bind to the same port twice and will fail.This PR calls
uniq!on the array to remove duplicate ports from thebindsarray. It also emits a warning whenbindsorportis called with an already existing port specified: