Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extconf.rb - don't use pkg_config('openssl') if '--with-openssl-dir' is used #2885

Merged
merged 1 commit into from
May 30, 2022

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented May 27, 2022

Description

If installing Puma with --with-openssl-dir, pkg_config('openssl') may locate the system OpenSSL, which is not desirable.

Hence, only use pkg_config('openssl') when --with-openssl-dir is not used.

See ruby/openssl#486

This problem has generated a few issues with macOS. If anyone with multiple OpenSSL installs (and a Ruby that is not using the system OpenSSL), can check this, it would be appreciated.

Note that this PR only affects using --with-openssl-dir with a Puma install.

Closes #2839. Not.sure

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg
Copy link
Member Author

Failed on the test skip added in PR #2883. Or, truffleruby fails, but truffleruby-head passes.

@MSP-Greg MSP-Greg merged commit 1dc1dec into puma:master May 30, 2022
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this pull request Sep 9, 2022
@MSP-Greg MSP-Greg deleted the 00-ssl-pkg-config branch September 28, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: implicit declaration of function 'SSL_get1_peer_certificate'
2 participants