extconf.rb - don't use pkg_config('openssl') if '--with-openssl-dir' is used #2885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If installing Puma with
--with-openssl-dir
,pkg_config('openssl')
may locate the system OpenSSL, which is not desirable.Hence, only use
pkg_config('openssl')
when--with-openssl-dir
is not used.See ruby/openssl#486
This problem has generated a few issues with macOS. If anyone with multiple OpenSSL installs (and a Ruby that is not using the system OpenSSL), can check this, it would be appreciated.
Note that this PR only affects using
--with-openssl-dir
with a Puma install.Closes #2839. Not.sure
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.