Escape SSL cert and filenames #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5ddf to
26cad69
Compare
Filenames with `+` would fail to load because it would be misinterpreted as a space. Since Puma already unescapes the query string, we should escape the value to fix this. We also make `cert` and `key` conditional in the query string because that gives a clearer error message: ``` ERROR: Please specify the SSL key via 'key=' or 'key_pem=' ``` Rather than: ``` puma/lib/puma/minissl.rb:218:in `check_file': Key file '' does not exist (ArgumentError) ```
26cad69 to
3a6e54b
Compare
dentarg
reviewed
Apr 13, 2022
stanhu
added a commit
to stanhu/puma
that referenced
this pull request
Apr 13, 2022
This was an oversight in puma#2855.
7 tasks
nateberkopec
pushed a commit
that referenced
this pull request
Apr 13, 2022
This was an oversight in #2855.
nateberkopec
pushed a commit
that referenced
this pull request
Aug 22, 2022
Filenames with `+` would fail to load because it would be misinterpreted as a space. Since Puma already unescapes the query string, we should escape the value to fix this. We also make `cert` and `key` conditional in the query string because that gives a clearer error message: ``` ERROR: Please specify the SSL key via 'key=' or 'key_pem=' ``` Rather than: ``` puma/lib/puma/minissl.rb:218:in `check_file': Key file '' does not exist (ArgumentError) ```
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
Filenames with `+` would fail to load because it would be misinterpreted as a space. Since Puma already unescapes the query string, we should escape the value to fix this. We also make `cert` and `key` conditional in the query string because that gives a clearer error message: ``` ERROR: Please specify the SSL key via 'key=' or 'key_pem=' ``` Rather than: ``` puma/lib/puma/minissl.rb:218:in `check_file': Key file '' does not exist (ArgumentError) ```
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
This was an oversight in puma#2855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filenames with
+would fail to load because it would bemisinterpreted as a space. Since Puma already unescapes the query
string, we should escape the value to fix this.
We also make
certandkeyconditional in the query string becausethat gives a clearer error message:
Rather than:
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.