Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new drift events to webhook resource #254

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add new drift events to webhook resource #254

merged 2 commits into from
Apr 23, 2024

Conversation

komalali
Copy link
Member

No description provided.

@komalali komalali force-pushed the komal/webhook-events branch from 27f8b5f to b0bbffe Compare April 23, 2024 22:46
@komalali komalali requested a review from IaroslavTitov April 23, 2024 22:47
IaroslavTitov
IaroslavTitov approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@IaroslavTitov IaroslavTitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to make codefreeze PR, perfect timing!

QQ: are value field magic strings that match code in Pulumi Cloud? I'm guessing so, just want to make they match, or if you tested these?

@komalali
Copy link
Member Author

@IaroslavTitov yeah they match here: https://github.com/pulumi/pulumi-service/blob/6eed4db07aa3d861941673cbb69f8ea1599161e1/cmd/service/model/webhooks.go#L60-L64

@komalali komalali merged commit 7f60277 into main Apr 23, 2024
13 checks passed
@komalali komalali deleted the komal/webhook-events branch April 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IaroslavTitov IaroslavTitov IaroslavTitov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@komalali @IaroslavTitov