-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide detailed error for removed apiVersions #809
Conversation
This is now RFR |
d47489e
to
708e81f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Is there a reason in the OP image that we're both warning && error'ing with the same message?
I'd imagine they'd be mutually exclusive, as a warning is a heads-up with no action required but is suggested, and an error is a true failure. As presented, I'd expect to only see an error that I'd have to fix because I'm using an unsupported group/version.
Thoughts?
Before creating any resource, check if the requested apiVersion has been deprecated/removed on the targeted version of k8s, and print a detailed error message if so. This should avoid confusion from users who try to use unsupported versions.
No, not a good reason. I'll make it mutually exclusive. |
708e81f
to
55dc50c
Compare
Looks great. nit: Can we link to the official k8s API docs as part of the message so that users can check them out if necessary? e.g. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.16 |
0423196
to
0eeb509
Compare
Proposed changes
Before creating any resource, check if the requested apiVersion
has been deprecated/removed on the targeted version of k8s,
and print a detailed error message if so. This should avoid
confusion from users who try to use unsupported versions.
Related issues (optional)