Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix renderYamlToDirectory generated manifests with apiVersion #2007

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Prefix renderYamlToDirectory generated manifests with apiVersion #2007

merged 3 commits into from
Jun 8, 2022

Conversation

RealityAnomaly
Copy link
Contributor

Proposed changes

Prefixes files generated by renderYamlToDirectory with the APIVersion to prevent conflicts.

Related issues (optional)

#2006

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@jkisk jkisk requested review from lblackstone and viveklak June 7, 2022 17:04
@viveklak
Copy link
Contributor

viveklak commented Jun 7, 2022

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2456234588

viveklak
viveklak approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@viveklak viveklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Left an optional suggestion. Could you please also add a changelog entry for the change?

@viveklak
Update provider/pkg/provider/provider.go
cd9fadb 
Co-authored-by: Vivek Lakshmanan <vivek@lakshmanan.ca>
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@RealityAnomaly
Copy link
Contributor Author

Thanks, I have done this.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@viveklak
Copy link
Contributor

viveklak commented Jun 8, 2022

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2462943794

@viveklak viveklak merged commit c759633 into pulumi:master Jun 8, 2022
@viveklak
Copy link
Contributor

viveklak commented Jun 8, 2022

Thanks for the contribution @citadelcore !

@RealityAnomaly RealityAnomaly deleted the feat/add-apiversion branch June 8, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

@lblackstone lblackstone Awaiting requested review from lblackstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealityAnomaly @viveklak