Fix provider diff #1869
Fix provider diff #1869
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
| } | ||
| if olds["suppressHelmHookWarnings"] != news["suppressHelmHookWarnings"] { | ||
| diffs = append(diffs, "suppressHelmHookWarnings") | ||
| } |
There was a problem hiding this comment.
Can we introspect on the schema and look through the config settings instead of hardcoding/checking these? Seems like that would avoid the whole possibility of falling out of sync here?
There was a problem hiding this comment.
Yeah, I think another option would be iterating the entire struct, and special-casing any we need to handle differently. That would at least give a default diff.
There was a problem hiding this comment.
Let me know how you want to proceed. Do the above now or merge this and follow-up. I do worry about the drift so the more we can standardize around schema guiding operations the better. This would also be a great endorsement for common logic living in a library across providers.
There was a problem hiding this comment.
I switched to iterating the keys. Let's figure out how to centralize this logic as a follow up.
More recent provider provider options were not showing up in the diff
8e3ae4f to
4a25f66
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
More recent provider provider options were not showing up in the diff
Related issues (optional)