Add integration tests for remaining resources #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds integration tests for the remaining construct libraries. Also adds mapping for one missing CCAPI resource (`AWS::Events::EventBusPolicy`) re #183
t0yv0
reviewed
Nov 11, 2024
| Dir: filepath.Join(getCwd(t), "misc-services"), | ||
| }) | ||
|
|
||
| integration.ProgramTest(t, &test) |
There was a problem hiding this comment.
A small assert on the outputs is appreciated!
t0yv0
approved these changes
Nov 11, 2024
flostadler
reviewed
Nov 11, 2024
integration/examples_nodejs_test.go
Outdated
| Dir: filepath.Join(getCwd(t), "misc-services"), | ||
| ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) { | ||
| repoName := stack.Outputs["repoName"].(string) | ||
| assert.Containsf(t, "testrepob5dda46f", repoName, "Expected repoName to contain 'testrepob5dda46f'; got %s", repoName) |
There was a problem hiding this comment.
Why do we expect exactly this suffix? The b5dda46f is random, right?
There was a problem hiding this comment.
This is the CDK generated suffix so it is a hash based on the construct tree. It will be the same everytime.
There was a problem hiding this comment.
Ah and I guess it's fine anyways because there shouldn't be any change to the tree as those would essentially cause a replacement (because the name changes), right?
Thanks for the explanation!
flostadler
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds integration tests for the remaining construct libraries.
Also adds mapping for one missing CCAPI resource
(
AWS::Events::EventBusPolicy)closes #183