chore: remove flaky websocket test #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
reviewed
Sep 3, 2024
| @@ -156,55 +148,22 @@ func retryFunc(t *testing.T, fn func() bool) error { | |||
| } | |||
| } | |||
|
|
|||
| // isConnected validates that the $connect lambda was triggered successfully by | |||
There was a problem hiding this comment.
I'm wondering whether we should leave the example in if it's too flaky.
It's not the best experience if somebody tries it out and can't get it working (even if the problem is not on the Pulumi end)
There was a problem hiding this comment.
Yeah you are probably right. I also think websockets is a weird example to pick, we should probably switch the example to just be a normal HTTP api.
There was a problem hiding this comment.
Good question! I think of examples and tests as serving two distinct purposes. If the test bits (verification) are flaky, but the users can still cd example/foo && pulumi up then it still might have value as an example and worth leaving in.
t0yv0
approved these changes
Sep 3, 2024
flostadler
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the websocket test is too flaky and has been failing
frequently (#157, #155). Removing the piece that validates the dynamodb
record exists in the table since that is the part that is too flaky.
fixes #157