Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle autocomplete-plus #358

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Bundle autocomplete-plus #358

merged 5 commits into from
Feb 7, 2023

Conversation

confused-Techie
Copy link
Member

This PR follows all previous guidelines on the topic.

  • Adds and updates a package-lock.json
  • Removes the MIT license file as it matches the repo license
  • Rebrands the README.md and package.json

Otherwise this PR bundles autocomplete-plus updating the pulsar package.json and yarn.lock

@confused-Techie
Copy link
Member Author

FYI: Seems an error was made when bundling and the incorrect commit SHA was used, missing some of the changes available on the tagged ref we were previously using. So this bundled autocomplete-plus is still using the outdated Atom Jasmine3 test runner. This will be resolved, but until then should not be merged since while tests pass locally, they do not pass in Ci

@confused-Techie
Copy link
Member Author

Alright, sorry about the temporary error.

This PR is now good to review with:

  • find-and-replace: 66 Failures (We expect 51 ± ~10 so this seems to fall into the expected range)
  • symbols-view: 2 Failures (We expect 2)
  • tree-view: 2 Failures (We expect 2)

So the tests are right where we would expect them, other than find-and-replace being a slight range that is hard to predict. So essentially this PR should be good to go.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this 100% matches the previously specified 1f056ef commit of our fork of autocomplete-plus (see this branch https://github.com/pulsar-edit/autocomplete-plus/tree/fix-outdated-test-lib)...

Other than in README.md deleting an obsolete Travis CI badge and rebranding an instance of "Atom" to "Pulsar", which makes sense to me.

Approved!

@confused-Techie
Copy link
Member Author

@DeeDeeG Thanks again for your review! I appreciate your time and effort! I'll resolve the conflicts on this one and get it merged!

@confused-Techie confused-Techie merged commit 9626019 into master Feb 7, 2023
@confused-Techie confused-Techie deleted the bundle-specific-refs branch February 7, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants