Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package_types filter breaking others #692

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix package_types filter breaking others #692

merged 1 commit into from
Jun 27, 2024

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Jun 26, 2024

fixes: #691

mdellweg
mdellweg approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like complete magic to me, how this config is used, but the change is fine.

Not related to this change, but is BandersnatchConfig.config a class variable?

@gerrod3
Copy link
Contributor Author

gerrod3 commented Jun 27, 2024

It looks like complete magic to me, how this config is used, but the change is fine.

Not related to this change, but is BandersnatchConfig.config a class variable?

BandersnatchConfig is a singleton object and the config variable is the parsed config options, it is initialized during init, but it is not a class variable.

@gerrod3 gerrod3 merged commit a37d040 into pulp:main Jun 27, 2024
16 checks passed
@patchback Patchback
Copy link

patchback bot commented Jun 27, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/a37d040b901d70a527c208fab9edef486039a205/pr-692

Backported as #693

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback Patchback
Copy link

patchback bot commented Jun 27, 2024 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/a37d040b901d70a527c208fab9edef486039a205/pr-692

Backported as #694

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 27, 2024
@gerrod3 @patchback
Merge pull request #692 from gerrod3/package-type-filter-fix
d0ff886 
Fix package_types filter breaking others

(cherry picked from commit a37d040)
patchback bot pushed a commit that referenced this pull request Jun 27, 2024
@gerrod3 @patchback
Merge pull request #692 from gerrod3/package-type-filter-fix
b72ceaa 
Fix package_types filter breaking others

(cherry picked from commit a37d040)
This was referenced Jun 27, 2024
Merged
Merged
@gerrod3 gerrod3 deleted the package-type-filter-fix branch June 27, 2024 14:04
gerrod3 added a commit that referenced this pull request Jun 27, 2024
@gerrod3
Merge pull request #692 from gerrod3/package-type-filter-fix
40cd198 
Fix package_types filter breaking others

(cherry picked from commit a37d040)
gerrod3 added a commit that referenced this pull request Jun 27, 2024
@gerrod3
Merge pull request #694 from pulp/patchback/backports/3.12/a37d040b90…
5e68d1b 
…1d70a527c208fab9edef486039a205/pr-692

[PR #692/a37d040b backport][3.12] Fix package_types filter breaking others
gerrod3 added a commit that referenced this pull request Jun 27, 2024
@gerrod3
Merge pull request #692 from gerrod3/package-type-filter-fix
580c676 
Fix package_types filter breaking others

(cherry picked from commit a37d040)
gerrod3 added a commit that referenced this pull request Jun 27, 2024
@gerrod3
Merge pull request #693 from pulp/patchback/backports/3.11/a37d040b90…
88a1d87 
…1d70a527c208fab9edef486039a205/pr-692

[PR #692/a37d040b backport][3.11] Fix package_types filter breaking others
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
backport-3.11 backport-3.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package_types remote filter breaks other filters
2 participants
@gerrod3 @mdellweg