Modernize tests to use new fixtures #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f478669 to
6f6aab4
Compare
mdellweg
reviewed
Jun 7, 2024
| entry_points={"pulpcore.plugin": ["pulp_python = pulp_python:default_app_config", ]}, | ||
| entry_points={ | ||
| "pulpcore.plugin": ["pulp_python = pulp_python:default_app_config"], | ||
| "pytest11": ["pulp_python = pulp_python.pytest_plugin"], |
There was a problem hiding this comment.
Is it really worth turning this into a pytest plugin? But also why not...
| def test_published_index( | ||
| python_bindings, | ||
| python_repo_with_sync, | ||
| python_remote_factory, |
There was a problem hiding this comment.
I'm beginning to wonder if we should put all the factories into the bindings fixture too.
[noissue]
mdellweg
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required work for my domains PR (and future RBAC PR). This brings pulp_python into modern Pulp testing era and removes its dependency on pulp_smash. Trimmed a lot of pointless tests, so hopefully the CI runs even faster.