Our import of FC,F from click.decorators isn't supported

[ggainey]

In pulpcore/cli/common/generic.py we do from click.decorators import FC, F. These are "convenient aliases", not part of click's supported API, and one of them "disappeared" in click-8.1.4. We need to not-rely on importing from click.

[ggainey]

Note: a quick experiment shows that click-8.1.5 still gives us lint failures:

(oci-env) (726_click-8-1-5) ~/github/Pulp3/pulp-cli $ pip freeze | grep mypy
mypy==1.4.1
mypy-extensions==1.0.0
(oci-env) (726_click-8-1-5) ~/github/Pulp3/pulp-cli $ make lint
mypy
pulpcore/cli/common/generic.py:1080: error: Argument 1 has incompatible type "Callable[[Arg(PulpCLIContext, 'pulp_ctx'), Arg(PulpEntityContext, 'entity_ctx'), Arg(int, 'limit'), Arg(int, 'offset'), KwArg(Any)], None]"; expected "Callable[[PulpCLIContext, Arg(PulpEntityContext, 'entity_ctx'), Arg(int, 'limit'), Arg(int, 'offset'), KwArg(Any)], None]"  [arg-type]
pulpcore/cli/common/generic.py:1080: note: This is likely because "callback" has named arguments: "pulp_ctx". Consider marking them positional-only
pulpcore/cli/common/generic.py:1080: error: Argument 1 has incompatible type "Callable[[Arg(PulpEntityContext, 'entity_ctx'), Arg(int, 'limit'), Arg(int, 'offset'), KwArg(Any)], None]"; expected "Callable[[PulpEntityContext, Arg(int, 'limit'), Arg(int, 'offset'), KwArg(Any)], None]"  [arg-type]
pulpcore/cli/common/generic.py:1080: note: This is likely because "None" has named arguments: "entity_ctx". Consider marking them positional-only

I think we want to wait for click-8.1.6; see pallets/click#2558 (comment) and pallets/click#2565 for community discussion.

[ggainey]

We're also running into python/mypy#15037 , which @mdellweg is addressing in the PR for this issue.