Releasing v4.28.4

.pubnub.yml

@@ -1,5 +1,12 @@
 ---
 changelog:
+  -
+    changes:
+      -
+        text: "Fixes issue of high cpu usage when heartbeat interval is not set."
+        type: bug
+    date: 2020-07-15
+    version: v4.28.4
   -
     changes:
       -
@@ -861,4 +868,4 @@ supported-platforms:
       - "Ubuntu 14.04 and up"
       - "Windows 7 and up"
     version: "Pubnub Javascript for Node"
-version: "4.28.3"
+version: "4.28.4"

CHANGELOG.md

@@ -1,3 +1,10 @@
+## [v4.28.4](https://github.com/pubnub/javascript/releases/tag/v4.28.4)
+July-15-2020
+
+[Full Changelog](https://github.com/pubnub/javascript/compare/v4.28.3...v4.28.4)
+
+- 🐛 Fixes issue of high cpu usage when heartbeat interval is not set. 
+
 ## [v4.28.3](https://github.com/pubnub/javascript/releases/tag/v4.28.3)
 July-15-2020
 

README.md

@@ -22,5 +22,5 @@ please use the [master_3x](https://github.com/pubnub/javascript/tree/master_3x)
 
 
 
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.min.js
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.3.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.min.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.28.4.js

dist/titanium/pubnub.js

@@ -1,4 +1,4 @@
-/*! 4.28.3 / Consumer  */
+/*! 4.28.4 / Consumer  */
 exports["PubNub"] =
 /******/ (function(modules) { // webpackBootstrap
 /******/ 	// The module cache
@@ -506,7 +506,7 @@ var _default = function () {
   }, {
     key: "getVersion",
     value: function getVersion() {
-      return '4.28.3';
+      return '4.28.4';
     }
   }, {
     key: "_addPnsdkSuffix",
@@ -3591,7 +3591,7 @@ var _default = function () {
     value: function _registerHeartbeatTimer() {
       this._stopHeartbeatTimer();
 
-      if (this._config.getHeartbeatInterval() === 0) {
+      if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
         return;
       }
 

dist/web/pubnub.js

@@ -1,4 +1,4 @@
-/*! 4.28.3 / Consumer  */
+/*! 4.28.4 / Consumer  */
 (function webpackUniversalModuleDefinition(root, factory) {
 	if(typeof exports === 'object' && typeof module === 'object')
 		module.exports = factory();
@@ -516,7 +516,7 @@ var _default = function () {
   }, {
     key: "getVersion",
     value: function getVersion() {
-      return '4.28.3';
+      return '4.28.4';
     }
   }, {
     key: "_addPnsdkSuffix",
@@ -3499,7 +3499,7 @@ var _default = function () {
     value: function _registerHeartbeatTimer() {
       this._stopHeartbeatTimer();
 
-      if (this._config.getHeartbeatInterval() === 0) {
+      if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
         return;
       }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pubnub",
-  "version": "4.28.3",
+  "version": "4.28.4",
   "author": "PubNub <support@pubnub.com>",
   "description": "Publish & Subscribe Real-time Messaging with PubNub",
   "bin": {},

src/core/components/config.js

@@ -307,7 +307,7 @@ export default class {
   }
 
   getVersion(): string {
-    return '4.28.3';
+    return '4.28.4';
   }
 
   _addPnsdkSuffix(name: string, suffix: string) {

src/core/components/subscription_manager.js

@@ -350,8 +350,8 @@ export default class {
   _registerHeartbeatTimer() {
     this._stopHeartbeatTimer();
 
-    // if the interval is 0, do not queue up heartbeating
-    if (this._config.getHeartbeatInterval() === 0) {
+    // if the interval is 0 or undefined, do not queue up heartbeating
+    if (this._config.getHeartbeatInterval() === 0 || this._config.getHeartbeatInterval() === undefined) {
       return;
     }
 

test/integration/operations/heartbeat.test.js

@@ -23,6 +23,7 @@ describe('heartbeat', () => {
       subscribeKey: 'mySubscribeKey',
       publishKey: 'myPublishKey',
       uuid: 'myUUID',
+      heartbeatInterval	:1, // for quick test of heartbeat calls
       announceSuccessfulHeartbeats: true,
     });
   });