Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagy to following route #8577

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Added pagy to following route #8577

merged 1 commit into from
Oct 16, 2020

Conversation

stacytonui
Copy link
Contributor

@stacytonui stacytonui commented Oct 14, 2020

Fixes #8574 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@stacytonui stacytonui requested a review from a team as a code owner October 14, 2020 10:52
@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2020

Code Climate has analyzed commit b07bc84 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #8577 into main will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8577   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         101      101           
  Lines        5901     5901           
=======================================
  Hits         4825     4825           
  Misses       1076     1076           
Impacted Files Coverage Δ
app/controllers/users_controller.rb 81.04% <0.00%> (ø)

@ghost
Copy link

ghost commented Oct 14, 2020

Waow @stacytonui nice one.

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stacytonui LGTM! 💯

@stacytonui
Copy link
Contributor Author

Yay thankyou! @Tlazypanda .. @karenefereyan Thankyouu

@ghost
Copy link

ghost commented Oct 14, 2020

Yay thankyou! @Tlazypanda .. @karenefereyan Thankyouu

Anytime dear. Well done

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great collaboration here! Looks perfect, thanks so much! Merging!

@jywarren jywarren merged commit 70cc858 into publiclab:main Oct 16, 2020
@ghost
Copy link

ghost commented Oct 16, 2020

Great collaboration here! Looks perfect, thanks so much! Merging!

Yay! Congrats to you @stacytonui

@stacytonui
Copy link
Contributor Author

Thankyouu!! @karenefereyan

piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagy for following route
3 participants