Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge ... and + buttons for more tags in sidebar #8386

Merged
merged 3 commits into from
Sep 15, 2020
Merged

merge ... and + buttons for more tags in sidebar #8386

merged 3 commits into from
Sep 15, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Sep 8, 2020

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Sep 8, 2020

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #8386 into main will increase coverage by 0.14%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8386      +/-   ##
==========================================
+ Coverage   81.87%   82.01%   +0.14%     
==========================================
  Files         101      101              
  Lines        5902     5900       -2     
==========================================
+ Hits         4832     4839       +7     
+ Misses       1070     1061       -9     
Impacted Files Coverage Δ
app/models/node.rb 91.69% <86.66%> (+0.32%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren
Copy link
Member Author

jywarren commented Sep 9, 2020

System test error, maybe expected:

ERROR["test_removing_tags_from_the_post", #<Minitest::Reporters::Suite:0x00007f81be15f058 @name="PostTest">, 150.319855386]
 test_removing_tags_from_the_post#PostTest (150.32s)
Minitest::UnexpectedError:         Capybara::ExpectationNotMet: expected to find visible css ".tags-list p.badge" 0 times, found 1 match: "everything"
            test/system/post_test.rb:60:in `block in <class:PostTest>'

@jywarren
Copy link
Member Author

page.assert_selector('.tags-list p.badge', :count => 0)

@jywarren
Copy link
Member Author

Hmm running into these temporary test changes from Alax in #7715 -let me try rejiggering them...

@jywarren jywarren merged commit d22fb96 into main Sep 15, 2020
jywarren added a commit that referenced this pull request Sep 15, 2020
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
jywarren added a commit that referenced this pull request Sep 22, 2020
#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to #8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* merge ... and + buttons for more tags in sidebar

* Update _tags.html.erb

* revert test changes from publiclab#7715
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
publiclab#8400)

* remove show more tags in favor of add tags now that both buttons do the same thing

follow-up to publiclab#8386

* tooltip

* Update _tagging.html.erb

* Update post_test.rb

* Update post_test.rb

* Update _tagging.html.erb

* try classname instead of id

* switch to a#tags-open

* re-show tags input on profile pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant