Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #8031

Closed
wants to merge 2 commits into from
Closed

Fixed Issue #8031

wants to merge 2 commits into from

Conversation

imanishbarnwal
Copy link
Member

Fixes #6551 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #8031 into main will increase coverage by 0.00%.
The diff coverage is 79.69%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #8031    +/-   ##
========================================
  Coverage   82.04%   82.05%            
========================================
  Files          97      100     +3     
  Lines        5643     5772   +129     
========================================
+ Hits         4630     4736   +106     
- Misses       1013     1036    +23     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.30% <ø> (ø)
app/controllers/users_controller.rb 82.29% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/models/user.rb 86.44% <12.50%> (-4.61%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/controllers/admin_controller.rb 80.00% <100.00%> (+1.94%) ⬆️
app/controllers/spam2_controller.rb 100.00% <100.00%> (ø)
app/controllers/tag_controller.rb 81.34% <100.00%> (-0.06%) ⬇️
app/helpers/spam2_helper.rb 100.00% <100.00%> (ø)
... and 3 more

@@ -26,7 +26,7 @@
<% end %>
<form id="questions_searchform" role="search" autocomplete="off" action="/post">
<div class="input-group">
<input tabindex="1" id="questions_searchform_input" type="text" name="title" class="<%= "disabled " if !current_user %>form-control search-query typeahead" qryType="questions" placeholder="type your question">
Copy link
Collaborator

@cesswairimu cesswairimu Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @imanishbarnwal and thanks for working on this...this file was not part of the issue you have linked...Is this for another issue? if so, kindly indicate...we normally have one pull request per issue. Thanks

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:18
@jywarren
Copy link
Member

jywarren commented Jul 7, 2020

I'll try retriggering the tests here!

@jywarren jywarren closed this Jul 7, 2020
@jywarren jywarren reopened this Jul 7, 2020
@cesswairimu
Copy link
Collaborator

This PR has been open for a long time and no activity/ reviews requested has not been addressed. We understand you might be busy and engaged on other things. I am closing this for now...please feel free to reopen if you get some time and would like to finish this. Rem to check if its still available before you reopen. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change function t to translations in dashboard/_comment_moderate
3 participants