-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed function t to translation in app/views/wiki/_header.html.erb … #7492
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## master #7492 +/- ##
===========================================
- Coverage 81.87% 50.83% -31.05%
===========================================
Files 97 97
Lines 5612 6964 +1352
===========================================
- Hits 4595 3540 -1055
- Misses 1017 3424 +2407
|
Screenshots 📸 (click to expand)7492-test_questions.png7492-test_embeddable_grids.png7492-test_signup.png7492-test_viewing_the_settings_page.png7492-test_tag_by_author_page.png7492-test_wiki_page_with_inline_grids.png7492-test_stats.png7492-test_viewing_the_dashboard.png7492-test_searching_an_item_from_the_homepage.png7492-test_signup_modal_form_validation.png7492-test_tag_stats.png7492-test_login_modal_form_validation.png7492-test_questions_shadow.png7492-test_login_modal.png7492-test_profile_page.png7492-test_comments.png7492-test_tags.png7492-test_signup_modal.png7492-test_wiki.png7492-test_methods.png7492-test_tag_page.png7492-test_blog_page_with_location_modal.png7492-test_tag_wildcard.png7492-test_signup_modal_disabled_submit_button_on_empty_username.png7492-test_embeddable_thumbnail_grids.png7492-test_front_page_with_navbar_search_autocomplete.png7492-test_spam_moderation_page.png7492-test_login.png7492-test_viewing_the_dropdown_menu.png7492-test_viewing_question_post.png7492-test_mobile_displays.png7492-test_simple-data-grapher_powertag.png7492-test_front.png7492-test_question_page.png7492-test_tag_contributors_page.png7492-test_blog.png7492-test_people.png7492-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is issue with the changes there are much more lines where the function t( ) needs to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="alert alert-warning"><%= raw t('wiki.show.page_has_no_tags', url: 'javascript: $(".tag-input").focus();') %></div> |
plots2/app/views/wiki/_header.html.erb
Line 52 in 6a39316
<div class="alert alert-success" style="border-color:#eee;background:#f8f8f8;color:#aaa;">« <%= raw t('wiki.show.back_to_wiki', :url1 => parent.path, :title => parent.latest.title) %></a></div> |
plots2/app/views/wiki/_header.html.erb
Line 59 in 6a39316
<li class="nav-item"><a class="nav-link" data-toggle="tab" href="#tab-overview"><%= t('wiki.show.overview') %></a></li> |
kindly change this functions t() also to translation()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey please also change the t
on line 2, 52 and 61
Hello, I am sorry but it seems like this was solved in another PR. Closing this...Let me know if you need help finding another issue. Thanks |
#7490
Fixes #7490 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!