Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed function t to translation in app/views/wiki/_header.html.erb … #7492

Closed
wants to merge 1 commit into from

Conversation

andysyme
Copy link

@andysyme andysyme commented Feb 14, 2020

#7490

Fixes #7490 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Feb 14, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #7492 into master will decrease coverage by 31.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7492       +/-   ##
===========================================
- Coverage   81.87%   50.83%   -31.05%     
===========================================
  Files          97       97               
  Lines        5612     6964     +1352     
===========================================
- Hits         4595     3540     -1055     
- Misses       1017     3424     +2407     
Impacted Files Coverage Δ
app/controllers/talk_controller.rb 100.00% <0.00%> (ø) ⬆️
app/mailers/password_reset_mailer.rb 100.00% <0.00%> (ø) ⬆️
app/models/drupal_content_field_mapper.rb 100.00% <0.00%> (ø) ⬆️
app/models/drupal_content_field_map_editor.rb 100.00% <0.00%> (ø) ⬆️
app/controllers/settings_controller.rb 88.88% <0.00%> (ø) ⬆️
app/controllers/features_controller.rb 80.70% <0.00%> (ø) ⬆️
app/controllers/admin_controller.rb 8.42% <0.00%> (-69.64%) ⬇️
app/controllers/search_controller.rb 30.50% <0.00%> (-67.17%) ⬇️
app/controllers/user_tags_controller.rb 21.48% <0.00%> (-62.80%) ⬇️
app/controllers/home_controller.rb 35.87% <0.00%> (-62.51%) ⬇️
... and 34 more

@andysyme andysyme closed this Feb 14, 2020
@andysyme andysyme reopened this Feb 14, 2020
@plotsbot
Copy link
Collaborator

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @andysyme Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖 #
Screenshots 📸 (click to expand)

7492-test_questions.png

7492-test_embeddable_grids.png

7492-test_signup.png

7492-test_viewing_the_settings_page.png

7492-test_tag_by_author_page.png

7492-test_wiki_page_with_inline_grids.png

7492-test_stats.png

7492-test_viewing_the_dashboard.png

7492-test_searching_an_item_from_the_homepage.png

7492-test_signup_modal_form_validation.png

7492-test_tag_stats.png

7492-test_login_modal_form_validation.png

7492-test_questions_shadow.png

7492-test_login_modal.png

7492-test_profile_page.png

7492-test_comments.png

7492-test_tags.png

7492-test_signup_modal.png

7492-test_wiki.png

7492-test_methods.png

7492-test_tag_page.png

7492-test_blog_page_with_location_modal.png

7492-test_tag_wildcard.png

7492-test_signup_modal_disabled_submit_button_on_empty_username.png

7492-test_embeddable_thumbnail_grids.png

7492-test_front_page_with_navbar_search_autocomplete.png

7492-test_spam_moderation_page.png

7492-test_login.png

7492-test_viewing_the_dropdown_menu.png

7492-test_viewing_question_post.png

7492-test_mobile_displays.png

7492-test_simple-data-grapher_powertag.png

7492-test_front.png

7492-test_question_page.png

7492-test_tag_contributors_page.png

7492-test_blog.png

7492-test_people.png

7492-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

Copy link
Member

@govindgoel govindgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is issue with the changes there are much more lines where the function t( ) needs to be changed

Copy link
Collaborator

@NitinBhasneria NitinBhasneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<div class="alert alert-warning"><%= raw t('wiki.show.page_has_no_tags', url: 'javascript: $(".tag-input").focus();') %></div>

<div class="alert alert-success" style="border-color:#eee;background:#f8f8f8;color:#aaa;">&laquo; <%= raw t('wiki.show.back_to_wiki', :url1 => parent.path, :title => parent.latest.title) %></a></div>

<li class="nav-item"><a class="nav-link" data-toggle="tab" href="#tab-overview"><%= t('wiki.show.overview') %></a></li>

kindly change this functions t() also to translation()

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🎉

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey please also change the t on line 2, 52 and 61

@cesswairimu
Copy link
Collaborator

Hello, I am sorry but it seems like this was solved in another PR. Closing this...Let me know if you need help finding another issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change function t to translation in app/views/wiki/_header.html.erb
6 participants