-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors on lel version bump to 2.1.9 #7340
Merged
jywarren
merged 4 commits into
publiclab:master
from
crisner:fix-build-errors-on-LEL-version-bump-to-2.1.9
Jan 24, 2020
Merged
Fix build errors on lel version bump to 2.1.9 #7340
jywarren
merged 4 commits into
publiclab:master
from
crisner:fix-build-errors-on-LEL-version-bump-to-2.1.9
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7340 +/- ##
=======================================
Coverage 81.73% 81.73%
=======================================
Files 97 97
Lines 5602 5602
=======================================
Hits 4579 4579
Misses 1023 1023 |
Closed
Amazing!!!! Merging now!!! |
jywarren
approved these changes
Jan 24, 2020
Hooray @crisner @nstjean @VladimirMikulic !!! |
Wohoo :) |
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
* bump LEL to 2.1.9 * Increase wait time in map test * Add baselayer and comment out layers * copying in @VladimirMikulic's system test optimizations Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
* bump LEL to 2.1.9 * Increase wait time in map test * Add baselayer and comment out layers * copying in @VladimirMikulic's system test optimizations Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7299