Updated t() to translation() #7339

mantinone · 2020-01-23T23:03:32Z

Fixes #6597 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome · 2020-01-23T23:03:34Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

codecov · 2020-01-23T23:14:46Z

Codecov Report

Merging #7339 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7339   +/-   ##
=======================================
  Coverage   81.73%   81.73%           
=======================================
  Files          97       97           
  Lines        5602     5602           
=======================================
  Hits         4579     4579           
  Misses       1023     1023

plotsbot · 2020-01-23T23:20:28Z

	1 Warning
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	3 Messages
📖	@mantinone Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
📖	#

Screenshots 📸 (click to expand)

7339-test_questions.png

7339-test_embeddable_grids.png

7339-test_signup.png

7339-test_viewing_the_settings_page.png

7339-test_tag_by_author_page.png

7339-test_wiki_page_with_inline_grids.png

7339-test_stats.png

7339-test_viewing_the_dashboard.png

7339-test_searching_an_item_from_the_homepage.png

7339-test_signup_modal_form_validation.png

7339-test_tag_stats.png

7339-test_login_modal_form_validation.png

7339-test_questions_shadow.png

7339-test_login_modal.png

7339-test_profile_page.png

7339-test_comments.png

7339-test_tags.png

7339-test_signup_modal.png

7339-test_wiki.png

7339-test_methods.png

7339-test_tag_page.png

7339-test_blog_page_with_location_modal.png

7339-test_tag_wildcard.png

7339-test_signup_modal_disabled_submit_button_on_empty_username.png

7339-test_embeddable_thumbnail_grids.png

7339-test_front_page_with_navbar_search_autocomplete.png

7339-test_spam_moderation_page.png

7339-test_login.png

7339-test_viewing_the_dropdown_menu.png

7339-test_viewing_question_post.png

7339-test_mobile_displays.png

7339-test_simple-data-grapher_powertag.png

7339-test_front.png

7339-test_question_page.png

7339-test_tag_contributors_page.png

7339-test_blog.png

7339-test_people.png

7339-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

mantinone · 2020-01-23T23:49:11Z

Am I supposed to ping @publiclab/reviewers when I have no questions?

I did this straight from the browser, and thus didn't make a branch for it. Should I redo it on a separate branch?

SidharthBansal · 2020-01-24T18:12:13Z

Can you please provide a screenshot for your changes on localhost?

mantinone · 2020-01-24T22:23:50Z

@SidharthBansal
I think this is the correct page -scrolled down to the Activity section - but I'm not 100% sure. I tried looking at the page before and after my changes, and I see no difference.

mantinone · 2020-01-29T19:43:22Z

@publiclab/reviewers
Hi! It's been a few days since I posted. I just wanted to check if this is a normal amount of turnaround time for review?

SidharthBansal · 2020-01-30T18:39:54Z

I just wanted to check if this is a normal amount of turnaround time for review

We try to review it asap. All mentors were busy in the Google Code In, so we are sorry, we were not able to review your changes

welcome · 2020-01-30T18:40:23Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

mantinone · 2020-01-30T22:09:29Z

Yay! Thank you!
Everything seems to look okay on the testing server, though I'm still not sure all the functionality that the Activity tab is supposed to have.

SidharthBansal · 2020-01-31T07:19:15Z

Please change language from the footer and see

mantinone · 2020-02-02T02:34:16Z

I'm not sure what you're asking. Can you please clarify?

SidharthBansal · 2020-02-02T10:36:34Z

If you change the language from the footer at localhost:port_number then you will be able to sense your changes are working correctly

mantinone · 2020-02-04T00:50:28Z

Oh, I see.

If I go to the actual website, I see the languages tab in the footer, but in my localhost version the footer is completely empty.
Also, in https://stable.publiclab.org/dashboard, the footer only contains "See recent code activity on GitHub Pulse.

The Code of Conduct applies to all spaces managed by the Public Lab community and non-profit, both online and in person."

Is this a sign something is wrong?

SidharthBansal · 2020-02-04T20:22:39Z

Everything is fine. Code is written in that way

…

On Tue, Feb 4, 2020 at 6:20 AM Max ***@***.***> wrote: Oh, I see. If I go to the actual website, I see the languages tab in the footer, but in my localhost version the footer is completely empty. Also, in https://stable.publiclab.org/dashboard, the footer only contains "See recent code activity on GitHub Pulse. The Code of Conduct applies to all spaces managed by the Public Lab community and non-profit, both online and in person." Is this a sign something is wrong? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#7339?email_source=notifications&email_token=AFAAEQ64TFI5SEGMJZDIACTRBC3VJA5CNFSM4KK6MQX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKV6JMQ#issuecomment-581690546>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ7CMP3T3NG4GCFVMQDRBC3VJANCNFSM4KK6MQXQ> .

SidharthBansal · 2020-02-04T20:23:04Z

You can help us with other issues if you want. thanks On Wed, Feb 5, 2020 at 1:52 AM Sidharth Bansal < bansal.sidharthcode@gmail.com> wrote:

…

Everything is fine. Code is written in that way On Tue, Feb 4, 2020 at 6:20 AM Max ***@***.***> wrote: > Oh, I see. > > If I go to the actual website, I see the languages tab in the footer, but > in my localhost version the footer is completely empty. > Also, in https://stable.publiclab.org/dashboard, the footer only > contains "See recent code activity on GitHub Pulse. > > The Code of Conduct applies to all spaces managed by the Public Lab > community and non-profit, both online and in person." > > Is this a sign something is wrong? > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#7339?email_source=notifications&email_token=AFAAEQ64TFI5SEGMJZDIACTRBC3VJA5CNFSM4KK6MQX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKV6JMQ#issuecomment-581690546>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAAEQ7CMP3T3NG4GCFVMQDRBC3VJANCNFSM4KK6MQXQ> > . >

Updated t() to translation()

5290b49

SidharthBansal approved these changes Jan 30, 2020

View reviewed changes

SidharthBansal merged commit f9fb4f1 into publiclab:master Jan 30, 2020

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020

Updated t() to translation() (publiclab#7339)

9f7091d

mantinone deleted the patch-1 branch February 4, 2020 22:05

NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020

Updated t() to translation() (publiclab#7339)

897412d

Updated t() to translation() #7339

Updated t() to translation() #7339

Conversation

mantinone commented Jan 23, 2020 • edited Loading

welcome bot commented Jan 23, 2020

codecov bot commented Jan 23, 2020 • edited Loading

Codecov Report

plotsbot commented Jan 23, 2020

7339-test_questions.png

7339-test_embeddable_grids.png

7339-test_signup.png

7339-test_viewing_the_settings_page.png

7339-test_tag_by_author_page.png

7339-test_wiki_page_with_inline_grids.png

7339-test_stats.png

7339-test_viewing_the_dashboard.png

7339-test_searching_an_item_from_the_homepage.png

7339-test_signup_modal_form_validation.png

7339-test_tag_stats.png

7339-test_login_modal_form_validation.png

7339-test_questions_shadow.png

7339-test_login_modal.png

7339-test_profile_page.png

7339-test_comments.png

7339-test_tags.png

7339-test_signup_modal.png

7339-test_wiki.png

7339-test_methods.png

7339-test_tag_page.png

7339-test_blog_page_with_location_modal.png

7339-test_tag_wildcard.png

7339-test_signup_modal_disabled_submit_button_on_empty_username.png

7339-test_embeddable_thumbnail_grids.png

7339-test_front_page_with_navbar_search_autocomplete.png

7339-test_spam_moderation_page.png

7339-test_login.png

7339-test_viewing_the_dropdown_menu.png

7339-test_viewing_question_post.png

7339-test_mobile_displays.png

7339-test_simple-data-grapher_powertag.png

7339-test_front.png

7339-test_question_page.png

7339-test_tag_contributors_page.png

7339-test_blog.png

7339-test_people.png

7339-test_wiki_revisions.png

mantinone commented Jan 23, 2020

SidharthBansal commented Jan 24, 2020

mantinone commented Jan 24, 2020

mantinone commented Jan 29, 2020

SidharthBansal commented Jan 30, 2020

welcome bot commented Jan 30, 2020

mantinone commented Jan 30, 2020

SidharthBansal commented Jan 31, 2020

mantinone commented Feb 2, 2020

SidharthBansal commented Feb 2, 2020

mantinone commented Feb 4, 2020

SidharthBansal commented Feb 4, 2020 via email

SidharthBansal commented Feb 4, 2020 via email

mantinone commented Jan 23, 2020 •

edited

Loading

codecov bot commented Jan 23, 2020 •

edited

Loading