Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) #6778

sap143 · 2019-11-14T10:16:29Z

Fix all the 11 changes t(..) to translation (..) in line number 9,11,34,37,58,59,60 inside plots2/app/views/home/subscriptions.html.erb

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

changed t(...) to translation(...) on line number 8

welcome · 2019-11-14T10:16:31Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

nstjean · 2019-11-14T14:53:27Z

Thanks! While I'm reviewing the code can you add the issue # at the top? The title also needs to be changed to be specific which file is being changed, since there are a lot of translation issues.

sap143 · 2019-11-15T14:48:07Z

@nstjean I have mentioned issue # and title

nstjean

The changes to home/subscriptions.html.erb look great!

We shouldn't have any changes to other files, though. Can you remove the changes to sidebar/_author.html.erb ?

nstjean · 2019-11-15T14:51:33Z

Here's a screenshot of the working code change.

nstjean

Great thanks! This is all set to merge.

sap143 · 2019-11-15T15:16:45Z

@nstjean Thanks

nstjean · 2019-11-15T15:27:06Z

@SidharthBansal The error is that no language set one again, hopefully you can get that all set.

SidharthBansal · 2019-11-15T15:47:06Z

Please provide a descriptive title.
Thanks for contributing at PL

SidharthBansal · 2019-11-15T15:57:24Z

Quick Suggestion: Go to the travis tests and check what error is happening.
See

First thing: we can remove that t->translation to other pr that causes this error
Second thing: we can solve that error in other pr by fixing the above test.

Thanks

nstjean · 2019-11-18T15:32:26Z

@SidharthBansal Ahhh, ok, so it's test_graph in test/unit/tag_selection_test.rb that is causing it? I'll take a look at it.

SidharthBansal · 2019-11-18T15:40:59Z

Yep

…

On Mon, 18 Nov 2019, 9:02 pm Natalie St Jean, ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> Ahhh, ok, so it's test_graph in test/unit/tag_selection_test.rb that is causing it? I'll take a look at it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6778?email_source=notifications&email_token=AFAAEQ2U7QUREZHYP33BU4DQUKYQ7A5CNFSM4JNJCUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEK2TCY#issuecomment-555067787>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYSVEXWUGD5ECJYW7DQUKYQ7ANCNFSM4JNJCUNQ> .

nstjean · 2019-11-18T15:56:06Z

@SidharthBansal When I run that test in my local it passes. So what do I do next?

SidharthBansal · 2019-11-18T16:02:53Z

Please read #6778 (comment)

nstjean · 2019-11-18T16:13:42Z

"we can remove that t->translation to other pr that causes this error" I don't know what this means, can you clarify? How do we know what PR causes this error? I don't know much about testing.

SidharthBansal · 2019-11-28T15:15:29Z

To understand testing please refer https://hackernoon.com/your-guide-to-testing-in-ruby-on-rails-5-c8bd122e38ad OR https://guides.rubyonrails.org/testing.html
In short, testing is done to ensure the implementation of working properly.

Try to read the failing test in the screenshot provided above. Detect the line number and file from the failing test. Then move that line from this PR to new PR.

Thanks

nstjean · 2019-11-29T14:05:51Z

Ok thanks!

nstjean · 2019-11-29T14:16:53Z

I ran the test in my local branch of this PR and it's passing.

SidharthBansal · 2019-11-29T16:17:33Z

Which command are you using?

…

On Fri, Nov 29, 2019 at 7:46 PM Natalie St Jean ***@***.***> wrote: I ran the test in my local and it's passing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6778?email_source=notifications&email_token=AFAAEQZOXVPSPDIG5HFVGBLQWEP5LA5CNFSM4JNJCUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFO64QQ#issuecomment-559803970>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ6YWQKY522E7UQAWDTQWEP5LANCNFSM4JNJCUNQ> .

nstjean · 2019-11-29T22:11:20Z

rails test test/system/screenshots_test.rb

SidharthBansal · 2019-11-30T08:24:03Z

can you run all the tests and see what is failing?

…

On Sat, Nov 30, 2019 at 3:41 AM Natalie St Jean ***@***.***> wrote: rails test test/system/screenshots_test.rb — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6778?email_source=notifications&email_token=AFAAEQ4V362MMKFIMCVJEB3QWGHQRA5CNFSM4JNJCUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPTG4I#issuecomment-559887217>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ7GUK3HSEBMWSKCITLQWGHQRANCNFSM4JNJCUNQ> .

nstjean · 2019-11-30T15:58:28Z

So when I run rails test I get 8 errors... but I'm seeing the same errors when I run the full tests on the master branch.

SidharthBansal · 2019-12-01T06:07:04Z

If errors are same in master and current changed branch, then I guess local is not showing error. Tests are just failing at Production. @gauravano @jywarren can you please help us in this. You both are working on this since a long time Thanks

…

On Sat, Nov 30, 2019 at 9:28 PM Natalie St Jean ***@***.***> wrote: So when I run rails test I get 8 errors... but I'm seeing the same errors when I run the full tests on the master branch. [image: ***@***.***: ~-Dev-Ruby-public-lab-plots2_007] <https://user-images.githubusercontent.com/49460529/69902856-38442680-1360-11ea-8196-20f28494386b.png> [image: ***@***.***: ~-Dev-Ruby-public-lab-plots2_006] <https://user-images.githubusercontent.com/49460529/69902859-3b3f1700-1360-11ea-9941-3acb6d399b44.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6778?email_source=notifications&email_token=AFAAEQ3AD23PRQQK4UNK5ZDQWKESJA5CNFSM4JNJCUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQLUDQ#issuecomment-559987214>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5NGEBWIFXB5MRB3OTQWKESJANCNFSM4JNJCUNQ> .

jywarren · 2019-12-02T19:26:39Z

Hi, all, sorry can you catch me up on this?

@SidharthBansal The error is that no language set one again, hopefully you can get that all set.

I found I wasn't able to test this locally because i couldn't set the language locally. But the recent PRs doing this have all worked fine, so I think it's OK... let me review the PR.

SidharthBansal · 2019-12-03T06:59:50Z

Just catching you as you indicated!

jywarren · 2019-12-03T18:43:24Z

The error is odd --


 FAIL["test_graph", #<Minitest::Reporters::Suite:0x0000556c121340d8 @name="TagSelectionTest">, 0.3586234310000691]
 test_graph#TagSelectionTest (0.36s)
        Expected: 16
          Actual: 20
        test/unit/tag_selection_test.rb:12:in `block in <class:TagSelectionTest>'
  319/319: [===============================] 100% Time: 00:00:24, Time: 00:00:24

I'm not sure it's related. So I'm restarting that test, let's see if it passes... ?

jywarren · 2019-12-03T19:05:02Z

Yay! Merging this now, thanks for sticking with it, we appreciate your help! And thanks to everyone who helped make this happen!

welcome · 2019-12-03T19:05:10Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

welcome · 2019-12-03T19:05:13Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

…om t(..) to translation (..) (publiclab#6778) * changed t(...) to translation(...) on line number 8 * Fixed all 11 changes t(..) to translation(..) * remove change from sidebar/_author.html.erb

sap143 added 3 commits November 13, 2019 11:06

changed t(...) to translation(...) on line number 8

b657a32

Merge pull request #1 from sap143/sap143-patch-1

2909cd1

changed t(...) to translation(...) on line number 8

Fixed all 11 changes t(..) to translation(..)

02a4de4

sap143 changed the title ~~changes all t to translation~~ Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) Nov 14, 2019

nstjean requested changes Nov 15, 2019

View reviewed changes

remove change from sidebar/_author.html.erb

202ba8f

nstjean approved these changes Nov 15, 2019

View reviewed changes

jywarren approved these changes Dec 3, 2019

View reviewed changes

jywarren merged commit dd06555 into publiclab:master Dec 3, 2019

nstjean mentioned this pull request Dec 22, 2019

Change function t to translation in home/subscriptions #6776

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) #6778

Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) #6778

sap143 commented Nov 14, 2019 •

edited

Loading

welcome bot commented Nov 14, 2019

nstjean commented Nov 14, 2019 •

edited

Loading

sap143 commented Nov 15, 2019

nstjean left a comment

nstjean commented Nov 15, 2019

nstjean left a comment

sap143 commented Nov 15, 2019

nstjean commented Nov 15, 2019

SidharthBansal commented Nov 15, 2019

SidharthBansal commented Nov 15, 2019

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 18, 2019 via email

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 18, 2019

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 28, 2019

nstjean commented Nov 29, 2019

nstjean commented Nov 29, 2019 •

edited

Loading

SidharthBansal commented Nov 29, 2019 via email

nstjean commented Nov 29, 2019

SidharthBansal commented Nov 30, 2019 via email

nstjean commented Nov 30, 2019

SidharthBansal commented Dec 1, 2019 via email

jywarren commented Dec 2, 2019

SidharthBansal commented Dec 3, 2019

jywarren commented Dec 3, 2019

jywarren commented Dec 3, 2019

welcome bot commented Dec 3, 2019

welcome bot commented Dec 3, 2019

Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) #6778

Fix all 11 changes in plots2/app/views/home/subscriptions.html.erb from t(..) to translation (..) #6778

Conversation

sap143 commented Nov 14, 2019 • edited Loading

welcome bot commented Nov 14, 2019

nstjean commented Nov 14, 2019 • edited Loading

sap143 commented Nov 15, 2019

nstjean left a comment

Choose a reason for hiding this comment

nstjean commented Nov 15, 2019

nstjean left a comment

Choose a reason for hiding this comment

sap143 commented Nov 15, 2019

nstjean commented Nov 15, 2019

SidharthBansal commented Nov 15, 2019

SidharthBansal commented Nov 15, 2019

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 18, 2019 via email

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 18, 2019

nstjean commented Nov 18, 2019

SidharthBansal commented Nov 28, 2019

nstjean commented Nov 29, 2019

nstjean commented Nov 29, 2019 • edited Loading

SidharthBansal commented Nov 29, 2019 via email

nstjean commented Nov 29, 2019

SidharthBansal commented Nov 30, 2019 via email

nstjean commented Nov 30, 2019

SidharthBansal commented Dec 1, 2019 via email

jywarren commented Dec 2, 2019

SidharthBansal commented Dec 3, 2019

jywarren commented Dec 3, 2019

jywarren commented Dec 3, 2019

welcome bot commented Dec 3, 2019

welcome bot commented Dec 3, 2019

sap143 commented Nov 14, 2019 •

edited

Loading

nstjean commented Nov 14, 2019 •

edited

Loading

nstjean commented Nov 29, 2019 •

edited

Loading