Cross-browser compatible styling for input[type=file] #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
@publiclab/reviewers |
|
@divyabaid16 @shivam15 can I have review here too please :) |
|
@sashadev-sky Works for me!! |
|
@gauravano can I please get a 2nd review on this so we can merge :) |
|
It works for me too @sashadev-sky |
|
@shivam15 @divyabaid16 Thank you to both of you :) I really appreciate you taking the time! @jywarren this one is ready for merge |
|
Awesome, thank you!!! |
grvsachdeva
reviewed
Apr 12, 2019
| @@ -0,0 +1,14 @@ | |||
| /* | |||
| ================================================================ | |||
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Apply styling * Add comments
digitaldina
pushed a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
* Apply styling * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5423 (<=== Add issue number here)
===============================================
After applying a
line-height: 0globally toinput[type=file]:Chrome: improved - now better
Firefox: stays the same (perfect)
Safari: improved -now perfect
===============================================
OLD ones pasted in from original issue for easy reference:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!