Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image upload in comments as well as preview #5321

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Fix image upload in comments as well as preview #5321

merged 3 commits into from
Apr 1, 2019

Conversation

ViditChitkara
Copy link
Member

Fixes #5229

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 31, 2019 •
edited
Loading

1 Message
📖 @ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Oh awesome! Can you share a gif? Thanks Vidit!!!

@ViditChitkara
Copy link
Member Author

I'll do, it's working fine with 'choose upload' button.
But, dragging and dropping an image causes it to be uploaded multiple times.

@ViditChitkara
Copy link
Member Author

Here is a preview of the fixed bug
test

@jywarren
Copy link
Member

jywarren commented Apr 1, 2019

Fantastic! Ready to merge?

@ViditChitkara
Copy link
Member Author

Yes!

@grvsachdeva
Copy link
Member

grvsachdeva commented Apr 1, 2019 via email

@ViditChitkara
Copy link
Member Author

Thanks a lot Gaurav!

@jywarren jywarren merged commit dd20161 into publiclab:master Apr 1, 2019
@jywarren
Copy link
Member

jywarren commented Apr 1, 2019

🎉 :-)))

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
@ViditChitkara @icarito
Fix image upload in comments as well as preview (publiclab#5321)
9de3efb 
* Fix image upload in comments as well as preview

* changes

* change
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@ViditChitkara @jywarren
Fix image upload in comments as well as preview (publiclab#5321)
bc12ee9 
* Fix image upload in comments as well as preview

* changes

* change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViditChitkara @plotsbot @jywarren @grvsachdeva