-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center aligned the rich editor #5232
Conversation
Looks ok - i mean, as good as it was before you started, in mobile view! I
wonder, is it shorter in rich text mode? Anything we can do to make it a
little easier to use from a phone?
Thank you so much!!!
…On Thu, Mar 21, 2019 at 4:30 PM Ananya Arun ***@***.***> wrote:
Also this doesnt affect the view on /post pages.
[image: post]
<https://user-images.githubusercontent.com/32260628/54782930-18435b80-4c46-11e9-984f-9de9a7f4bf2e.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9X-Mrd-XFTy1sT9eaLLbbKbhGvVks5vY-ulgaJpZM4cCTYI>
.
|
Hmm can we decrease the height of the box ? Would that help ? |
sure, but we ought to do it only on narrower screens. Could you do so with
a @media css query? https://developer.mozilla.org/en-US/docs/Web/CSS/@media
…On Thu, Mar 21, 2019 at 4:34 PM Ananya Arun ***@***.***> wrote:
Hmm can we decrease the height of the box ? Would that help ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-DyYnxPI2JzrDoYHXBkqlfitNAhks5vY-ytgaJpZM4cCTYI>
.
|
Sure ill make that change 😃 |
Generated by 🚫 Danger |
Hey @ananyaarun, want any help with this PR? Thanks! |
Hey @gauravano , There were some issues with the media query in mobile view, But I'll give this another try and get back to you asap. Thanks! |
Okay. Thanks @ananyaarun! |
@gauravano , sorry I haven't been able to look at this yet. Got caught up with college work. I have my final exams till may first week. I'll do this and other pending issues positively then :) |
No issue @ananyaarun. All the best for exams! |
Please resolve the conflicts whenever you get some time. |
Hi @ananyaarun, can you update the PR now if you are free? |
Hi, I'm going to close this out to give someone else a chance at a fix, thanks so much! |
Fixes #5150
rake test
@publiclab/reviewers
for help, in a comment belowThanks!