Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center aligned the rich editor #5232

Closed
wants to merge 3 commits into from

Conversation

ananyaarun
Copy link
Member

@ananyaarun ananyaarun commented Mar 21, 2019

Fixes #5150

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

editor

mobile

Thanks!

@ananyaarun
Copy link
Member Author

Also this doesnt affect the view on /post pages.

post

@jywarren
Copy link
Member

jywarren commented Mar 21, 2019 via email

@ananyaarun
Copy link
Member Author

Hmm can we decrease the height of the box ? Would that help ?

@jywarren
Copy link
Member

jywarren commented Mar 21, 2019 via email

@ananyaarun
Copy link
Member Author

Sure ill make that change 😃

@plotsbot
Copy link
Collaborator

2 Messages
📖 @ananyaarun Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@grvsachdeva
Copy link
Member

Hey @ananyaarun, want any help with this PR? Thanks!

@ananyaarun
Copy link
Member Author

Hey @gauravano , There were some issues with the media query in mobile view, But I'll give this another try and get back to you asap. Thanks!

@grvsachdeva
Copy link
Member

Okay. Thanks @ananyaarun!

@ananyaarun
Copy link
Member Author

@gauravano , sorry I haven't been able to look at this yet. Got caught up with college work. I have my final exams till may first week. I'll do this and other pending issues positively then :)
Thanks!

@grvsachdeva
Copy link
Member

No issue @ananyaarun. All the best for exams!

@SidharthBansal
Copy link
Member

Please resolve the conflicts whenever you get some time.
Thanks

@grvsachdeva
Copy link
Member

Hi @ananyaarun, can you update the PR now if you are free?

@ananyaarun
Copy link
Member Author

@gauravano , I resolved the conflicts but after the bootstrap update this page looks very different from what it was before when i started working on it and it looks more aligned to the left than before and narrowed down as well.
1

@jywarren
Copy link
Member

jywarren commented Oct 5, 2019

Hi, I'm going to close this out to give someone else a chance at a fix, thanks so much!

@jywarren jywarren closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center align the question form
5 participants